Currently, we have an AnimationEffect class with read-write members and a KeyframeEffect subclasses with read-write members. The spec has an AnimationEffectReadOnly class, with read-only members, a KeyframeEffectReadOnly subclass, with read-only members, and then the KeyframeEffect subclass (of KeyframeEffectReadOnly) with read-write members.
Created attachment 333403 [details] Patch
Attachment 333403 [details] did not pass style-queue: ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:430: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 333447 [details] Patch
Created attachment 333454 [details] Patch
Attachment 333454 [details] did not pass style-queue: ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:430: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 333454 [details] Patch Attachment 333454 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6427638 New failing tests: imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html
Created attachment 333460 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 333454 [details] Patch Attachment 333454 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6427813 New failing tests: imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html
Created attachment 333463 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333454 [details] Patch Attachment 333454 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6427866 New failing tests: imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html
Created attachment 333467 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 333469 [details] Patch
Attachment 333469 [details] did not pass style-queue: ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:430: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r228333: <https://trac.webkit.org/changeset/228333>
<rdar://problem/37398113>