Bug 182608 - [Web Animations] Refactor AnimationEffect and KeyframeEffect into AnimationEffectReadOnly, KeyframeEffectReadOnly and KeyframeEffect
Summary: [Web Animations] Refactor AnimationEffect and KeyframeEffect into AnimationEf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-08 11:33 PST by Antoine Quint
Modified: 2018-02-09 11:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (309.80 KB, patch)
2018-02-08 12:03 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (308.06 KB, patch)
2018-02-08 23:37 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (308.84 KB, patch)
2018-02-09 00:11 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.77 MB, application/zip)
2018-02-09 01:09 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews103 for mac-sierra (2.23 MB, application/zip)
2018-02-09 01:20 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (2.97 MB, application/zip)
2018-02-09 01:49 PST, EWS Watchlist
no flags Details
Patch (303.30 KB, patch)
2018-02-09 01:52 PST, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-08 11:33:21 PST
Currently, we have an AnimationEffect class with read-write members and a KeyframeEffect subclasses with read-write members. The spec has an AnimationEffectReadOnly class, with read-only members, a KeyframeEffectReadOnly subclass, with read-only members, and then the KeyframeEffect subclass (of KeyframeEffectReadOnly) with read-write members.
Comment 1 Antoine Quint 2018-02-08 12:03:26 PST
Created attachment 333403 [details]
Patch
Comment 2 EWS Watchlist 2018-02-08 12:06:37 PST
Attachment 333403 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:430:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antoine Quint 2018-02-08 23:37:31 PST
Created attachment 333447 [details]
Patch
Comment 4 Antoine Quint 2018-02-09 00:11:11 PST
Created attachment 333454 [details]
Patch
Comment 5 EWS Watchlist 2018-02-09 00:14:16 PST
Attachment 333454 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:430:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 EWS Watchlist 2018-02-09 01:09:52 PST
Comment on attachment 333454 [details]
Patch

Attachment 333454 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6427638

New failing tests:
imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html
Comment 7 EWS Watchlist 2018-02-09 01:09:53 PST
Created attachment 333460 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-02-09 01:20:36 PST
Comment on attachment 333454 [details]
Patch

Attachment 333454 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6427813

New failing tests:
imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html
Comment 9 EWS Watchlist 2018-02-09 01:20:38 PST
Created attachment 333463 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-02-09 01:49:52 PST
Comment on attachment 333454 [details]
Patch

Attachment 333454 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6427866

New failing tests:
imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html
imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html
Comment 11 EWS Watchlist 2018-02-09 01:49:54 PST
Created attachment 333467 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Antoine Quint 2018-02-09 01:52:29 PST
Created attachment 333469 [details]
Patch
Comment 13 EWS Watchlist 2018-02-09 01:54:16 PST
Attachment 333469 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:430:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Antoine Quint 2018-02-09 11:11:40 PST
Committed r228333: <https://trac.webkit.org/changeset/228333>
Comment 15 Radar WebKit Bug Importer 2018-02-09 11:12:28 PST
<rdar://problem/37398113>