Bug 182594 - Remove JavaScriptCore/ForwardingHeaders directory
Summary: Remove JavaScriptCore/ForwardingHeaders directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-07 18:54 PST by Don Olmstead
Modified: 2018-02-08 17:10 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2018-02-07 19:41 PST, Don Olmstead
mark.lam: review+
don.olmstead: commit-queue-
Details | Formatted Diff | Diff
Patch (8.71 KB, patch)
2018-02-08 12:04 PST, Don Olmstead
bburg: commit-queue-
Details | Formatted Diff | Diff
Patch (8.91 KB, patch)
2018-02-08 13:10 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-02-07 18:54:02 PST
Let's find out if this is possible as well.
Comment 1 Don Olmstead 2018-02-07 19:41:24 PST
Created attachment 333354 [details]
Patch
Comment 2 Don Olmstead 2018-02-07 20:16:30 PST
Comment on attachment 333354 [details]
Patch

Apple bots are coming back green so maybe we can just do this? I'm not sure if this will have any effect on the Apple internal builds though.
Comment 3 Mark Lam 2018-02-07 20:32:01 PST
Comment on attachment 333354 [details]
Patch

r=me.  We can roll back out if it breaks stuff.
Comment 4 Don Olmstead 2018-02-08 12:04:37 PST
Created attachment 333404 [details]
Patch
Comment 5 BJ Burg 2018-02-08 13:00:16 PST
In file included from /tmp/g-ir-cpp-hd5ja0ts.c:31:0:
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/UIProcess/API/gtk/WebKitJavascriptResult.h:27:35: fatal error: JavaScriptCore/JSBase.h: No such file or directory
 #include <JavaScriptCore/JSBase.h>
                                   ^
Comment 6 Don Olmstead 2018-02-08 13:04:12 PST
(In reply to Brian Burg from comment #5)
> In file included from /tmp/g-ir-cpp-hd5ja0ts.c:31:0:
> /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/UIProcess/API/gtk/
> WebKitJavascriptResult.h:27:35: fatal error: JavaScriptCore/JSBase.h: No
> such file or directory
>  #include <JavaScriptCore/JSBase.h>
>                                    ^

Yea this seems to be a GTK only failure. I think it has to do with what I took out around https://trac.webkit.org/browser/trunk/Source/WebKit/PlatformGTK.cmake#L1146

Maybe Michael would have an idea there. I think it would have caught it in the FORWARDING_HEADERS_DIR though..
Comment 7 Don Olmstead 2018-02-08 13:10:28 PST
Created attachment 333415 [details]
Patch

Lets see if this makes GTK happy
Comment 8 Don Olmstead 2018-02-08 14:25:11 PST
I have no idea where the other bots are but they seemed happy with the last patch. I guess when jsc comes back I'll cq+ it and if it breaks something we'll roll it out.
Comment 9 WebKit Commit Bot 2018-02-08 17:09:42 PST
Comment on attachment 333415 [details]
Patch

Clearing flags on attachment: 333415

Committed r228302: <https://trac.webkit.org/changeset/228302>
Comment 10 WebKit Commit Bot 2018-02-08 17:09:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-02-08 17:10:24 PST
<rdar://problem/37372672>