Bug 182583 - [Curl] Cookie Database has some warnings when compiled in clang
Summary: [Curl] Cookie Database has some warnings when compiled in clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-07 15:01 PST by Christopher Reid
Modified: 2018-02-07 16:41 PST (History)
6 users (show)

See Also:

Attachments
patch (5.44 KB, patch)
2018-02-07 15:08 PST, Christopher Reid 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2018-02-07 15:01:23 PST 
Here are the warnings:
    - Unused parameters in CookieJarCurlDatabase and CookieJarDB.
    - The NetworkStorageSessionCurl constructor has a different order than its header.
    - I accidentally had a '#pragma once' in CookieJarCurlDatabase.cpp.
    - CookieJarDB.cpp(175,26): warning : missing field 'st_ino' initializer [-Wmissing-field-initializers]
Comment 1 Christopher Reid 2018-02-07 15:08:45 PST 
Created attachment 333319 [details]
patch
Comment 2 WebKit Commit Bot 2018-02-07 16:39:22 PST 
Comment on attachment 333319 [details]
patch

Clearing flags on attachment: 333319

Committed r228250: <https://trac.webkit.org/changeset/228250>
Comment 3 WebKit Commit Bot 2018-02-07 16:39:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-02-07 16:41:03 PST 
<rdar://problem/37332502>