RESOLVED FIXED182569
Use invalidation rulesets for attribute selectors 
https://bugs.webkit.org/show_bug.cgi?id=182569
Summary Use invalidation rulesets for attribute selectors
Antti Koivisto
Reported 2018-02-07 07:52:51 PST
More accurate style invalidation on attribute changes.
Attachments
patch (24.20 KB, patch)
2018-02-07 08:15 PST, Antti Koivisto 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.23 MB, application/zip)
2018-02-07 09:15 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.62 MB, application/zip)
2018-02-07 09:21 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.30 MB, application/zip)
2018-02-07 09:45 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews115 for mac-sierra (2.96 MB, application/zip)
2018-02-07 09:47 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews201 for win-future (11.56 MB, application/zip)
2018-02-07 10:22 PST, EWS Watchlist 		no flags
Details
patch (27.03 KB, patch)
2018-02-08 03:17 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-02-07 08:15:14 PST
Created attachment 333287 [details] patch
EWS Watchlist
Comment 2 2018-02-07 09:15:37 PST
Comment on attachment 333287 [details] patch Attachment 333287 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6400085 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html fast/shadow-dom/css-scoping-slotted-invalidation.html
EWS Watchlist
Comment 3 2018-02-07 09:15:39 PST
Created attachment 333292 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 4 2018-02-07 09:21:46 PST
Comment on attachment 333287 [details] patch Attachment 333287 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6400103 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html fast/shadow-dom/css-scoping-slotted-invalidation.html
EWS Watchlist
Comment 5 2018-02-07 09:21:47 PST
Created attachment 333293 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-02-07 09:45:31 PST
Comment on attachment 333287 [details] patch Attachment 333287 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6400122 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html fast/shadow-dom/css-scoping-slotted-invalidation.html
EWS Watchlist
Comment 7 2018-02-07 09:45:32 PST
Created attachment 333297 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8 2018-02-07 09:47:55 PST
Comment on attachment 333287 [details] patch Attachment 333287 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6400147 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html fast/shadow-dom/css-scoping-slotted-invalidation.html
EWS Watchlist
Comment 9 2018-02-07 09:47:56 PST
Created attachment 333298 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 10 2018-02-07 10:21:51 PST
Comment on attachment 333287 [details] patch Attachment 333287 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6400520 New failing tests: fast/shadow-dom/css-scoping-slotted-invalidation.html
EWS Watchlist
Comment 11 2018-02-07 10:22:02 PST
Created attachment 333302 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Antti Koivisto
Comment 12 2018-02-08 03:17:25 PST
Created attachment 333366 [details] patch
WebKit Commit Bot
Comment 13 2018-02-08 11:48:34 PST
Comment on attachment 333366 [details] patch Clearing flags on attachment: 333366 Committed r228285: <https://trac.webkit.org/changeset/228285>
WebKit Commit Bot
Comment 14 2018-02-08 11:48:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-02-08 11:53:22 PST
<rdar://problem/37360451>
Note You need to log in before you can comment on or make changes to this bug.