Bug 182569 - Use invalidation rulesets for attribute selectors
Summary: Use invalidation rulesets for attribute selectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-07 07:52 PST by Antti Koivisto
Modified: 2018-02-08 11:53 PST (History)
5 users (show)

See Also:


Attachments
patch (24.20 KB, patch)
2018-02-07 08:15 PST, Antti Koivisto
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.23 MB, application/zip)
2018-02-07 09:15 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.62 MB, application/zip)
2018-02-07 09:21 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.30 MB, application/zip)
2018-02-07 09:45 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (2.96 MB, application/zip)
2018-02-07 09:47 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews201 for win-future (11.56 MB, application/zip)
2018-02-07 10:22 PST, EWS Watchlist
no flags Details
patch (27.03 KB, patch)
2018-02-08 03:17 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-02-07 07:52:51 PST
More accurate style invalidation on attribute changes.
Comment 1 Antti Koivisto 2018-02-07 08:15:14 PST
Created attachment 333287 [details]
patch
Comment 2 EWS Watchlist 2018-02-07 09:15:37 PST
Comment on attachment 333287 [details]
patch

Attachment 333287 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6400085

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html
fast/shadow-dom/css-scoping-slotted-invalidation.html
Comment 3 EWS Watchlist 2018-02-07 09:15:39 PST
Created attachment 333292 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-02-07 09:21:46 PST
Comment on attachment 333287 [details]
patch

Attachment 333287 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6400103

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html
fast/shadow-dom/css-scoping-slotted-invalidation.html
Comment 5 EWS Watchlist 2018-02-07 09:21:47 PST
Created attachment 333293 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-02-07 09:45:31 PST
Comment on attachment 333287 [details]
patch

Attachment 333287 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6400122

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html
fast/shadow-dom/css-scoping-slotted-invalidation.html
Comment 7 EWS Watchlist 2018-02-07 09:45:32 PST
Created attachment 333297 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-02-07 09:47:55 PST
Comment on attachment 333287 [details]
patch

Attachment 333287 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6400147

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html
fast/shadow-dom/css-scoping-slotted-invalidation.html
Comment 9 EWS Watchlist 2018-02-07 09:47:56 PST
Created attachment 333298 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-02-07 10:21:51 PST
Comment on attachment 333287 [details]
patch

Attachment 333287 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6400520

New failing tests:
fast/shadow-dom/css-scoping-slotted-invalidation.html
Comment 11 EWS Watchlist 2018-02-07 10:22:02 PST
Created attachment 333302 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 12 Antti Koivisto 2018-02-08 03:17:25 PST
Created attachment 333366 [details]
patch
Comment 13 WebKit Commit Bot 2018-02-08 11:48:34 PST
Comment on attachment 333366 [details]
patch

Clearing flags on attachment: 333366

Committed r228285: <https://trac.webkit.org/changeset/228285>
Comment 14 WebKit Commit Bot 2018-02-08 11:48:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-02-08 11:53:22 PST
<rdar://problem/37360451>