Bug 182539 – Add missing #if ENABLE(VIDEO) after r228092.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ross Kirsling]

Created attachment 333188 [details]
Patch

Fix for https://bugs.webkit.org/show_bug.cgi?id=182388.

Definition of ImageBitmap::taintsOrigin must be guarded with ENABLE(VIDEO), otherwise the following error occurs with the feature turned off:

> member access into incomplete type 'WebCore::HTMLVideoElement'

[WebKit Commit Bot]

Comment on attachment 333188 [details]
Patch

Rejecting attachment 333188 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333188, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
org/git/WebKit
   588764ad5db..d90d89507ca  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 228183 = 588764ad5db0553c0876b9ed9429030c7457ab05
r228184 = d90d89507ca5dfcb0a7fd1d7271562255300b10b
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/6385177

[EWS Watchlist]

Comment on attachment 333188 [details]
Patch

Attachment 333188 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6385009

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html

[EWS Watchlist]

Created attachment 333195 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Ross Kirsling]

Created attachment 333201 [details]
Patch

[EWS Watchlist]

Comment on attachment 333201 [details]
Patch

Rejecting attachment 333201 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Ross Kirsling]

Created attachment 333202 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 333202 [details]
Patch for landing

Clearing flags on attachment: 333202

Committed r228186: <https://trac.webkit.org/changeset/228186>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37285319>

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Oops, sorry about that.