Bug 182539 - Add missing #if ENABLE(VIDEO) after r228092.
Summary: Add missing #if ENABLE(VIDEO) after r228092.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-06 10:22 PST by Ross Kirsling
Modified: 2018-02-07 07:51 PST (History)
10 users (show)

See Also:


Attachments
Patch (857 bytes, patch)
2018-02-06 10:22 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.21 MB, application/zip)
2018-02-06 11:26 PST, EWS Watchlist
no flags Details
Patch (1.60 KB, patch)
2018-02-06 12:16 PST, Ross Kirsling
cdumez: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (1.60 KB, patch)
2018-02-06 12:19 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-02-06 10:22:47 PST
Created attachment 333188 [details]
Patch

Fix for https://bugs.webkit.org/show_bug.cgi?id=182388.

Definition of ImageBitmap::taintsOrigin must be guarded with ENABLE(VIDEO), otherwise the following error occurs with the feature turned off:

> member access into incomplete type 'WebCore::HTMLVideoElement'
Comment 1 WebKit Commit Bot 2018-02-06 11:22:11 PST
Comment on attachment 333188 [details]
Patch

Rejecting attachment 333188 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333188, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
org/git/WebKit
   588764ad5db..d90d89507ca  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 228183 = 588764ad5db0553c0876b9ed9429030c7457ab05
r228184 = d90d89507ca5dfcb0a7fd1d7271562255300b10b
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/6385177
Comment 2 EWS Watchlist 2018-02-06 11:26:40 PST
Comment on attachment 333188 [details]
Patch

Attachment 333188 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6385009

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html
Comment 3 EWS Watchlist 2018-02-06 11:26:41 PST
Created attachment 333195 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Ross Kirsling 2018-02-06 12:16:47 PST
Created attachment 333201 [details]
Patch
Comment 5 EWS Watchlist 2018-02-06 12:17:17 PST
Comment on attachment 333201 [details]
Patch

Rejecting attachment 333201 [details] from review queue.

ross.kirsling@sony.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 Ross Kirsling 2018-02-06 12:19:30 PST
Created attachment 333202 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-02-06 12:55:13 PST
Comment on attachment 333202 [details]
Patch for landing

Clearing flags on attachment: 333202

Committed r228186: <https://trac.webkit.org/changeset/228186>
Comment 8 WebKit Commit Bot 2018-02-06 12:55:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-02-06 12:56:36 PST
<rdar://problem/37285319>
Comment 10 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-02-07 07:51:24 PST
Oops, sorry about that.