WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182535
Service workers registrations are saved to disk before the install / activation succeeds
https://bugs.webkit.org/show_bug.cgi?id=182535
Summary
Service workers registrations are saved to disk before the install / activati...
Chris Dumez
Reported
2018-02-06 09:38:55 PST
Service workers registrations are saved to disk before the install / activation succeeds. This means if the browser exists before the install / activation succeeds, we may restore from disk a registration with an “active” worker which may have never been installed / activated.
Attachments
Patch
(2.58 KB, patch)
2018-02-06 09:43 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(2.58 KB, patch)
2018-02-06 10:08 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-02-06 09:39:08 PST
<
rdar://problem/36591485
>
Chris Dumez
Comment 2
2018-02-06 09:43:07 PST
Created
attachment 333182
[details]
Patch
youenn fablet
Comment 3
2018-02-06 10:03:39 PST
Comment on
attachment 333182
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=333182&action=review
> Source/WebCore/ChangeLog:10 > + This means if the browser exists before the install / activation succeeds, we may restore
s/exists/exits
> Source/WebCore/ChangeLog:12 > + activated.
Indeed, this is in particular important for service worker doing some cache storage operations only in install step.
Chris Dumez
Comment 4
2018-02-06 10:08:49 PST
Created
attachment 333186
[details]
Patch
WebKit Commit Bot
Comment 5
2018-02-06 10:43:54 PST
Comment on
attachment 333186
[details]
Patch Clearing flags on attachment: 333186 Committed
r228180
: <
https://trac.webkit.org/changeset/228180
>
WebKit Commit Bot
Comment 6
2018-02-06 10:43:56 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug