RESOLVED FIXED 182502
[GTK][WPE] Enable modern media controls 
https://bugs.webkit.org/show_bug.cgi?id=182502
Summary [GTK][WPE] Enable modern media controls
Zan Dobersek
Reported 2018-02-05 12:13:54 PST
Unskipped in r228097, but are failing and timing out aplenty. https://trac.webkit.org/changeset/228097/webkit
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-02-05 12:56:25 PST
They're failing and timing out because we don't use modern media controls.
Xabier Rodríguez Calvar
Comment 2 2018-02-06 01:45:08 PST
I think the wisest thing here is flag the tests for modern controls and in the case of WPE, it might be interesting to use the GTK+ ones, though I think there could be some theming issues with the iconns that would need to be solved.
Xabier Rodríguez Calvar
Comment 3 2018-02-06 01:45:56 PST
Either that or we implement those modern controls, which would require contact with GNOME designers, etc.
Lauro Moura
Comment 4 2021-03-24 22:43:52 PDT
r274810 unskipped the modern-media-control tests alongside other media-related changes and the GTK layout test step was exiting early with many modern-media-controls related issues. I've re-skipped the main folders back in r275010, althouth there are other tests failing related to this. Link to the first failing build: https://build.webkit.org/#/builders/57/builds/772
Philippe Normand
Comment 5 2022-05-29 10:23:34 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1147
EWS
Comment 6 2022-06-02 08:37:47 PDT
Committed r295128 (251219@main): <https://commits.webkit.org/251219@main> Reviewed commits have been landed. Closing PR #1147 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.