Bug 182502 - [GTK][WPE] Enable modern media controls tests
Summary: [GTK][WPE] Enable modern media controls tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2018-02-05 12:13 PST by Zan Dobersek
Modified: 2018-02-06 01:45 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-02-05 12:13:54 PST
Unskipped in r228097, but are failing and timing out aplenty.
https://trac.webkit.org/changeset/228097/webkit
Comment 1 Michael Catanzaro 2018-02-05 12:56:25 PST
They're failing and timing out because we don't use modern media controls.
Comment 2 Xabier Rodríguez Calvar 2018-02-06 01:45:08 PST
I think the wisest thing here is flag the tests for modern controls and in the case of WPE, it might be interesting to use the GTK+ ones, though I think there could be some theming issues with the iconns that would need to be solved.
Comment 3 Xabier Rodríguez Calvar 2018-02-06 01:45:56 PST
Either that or we implement those modern controls, which would require contact with GNOME designers, etc.