Bug 182498 - [cmake] Fix build with ICU configured without collation support
Summary: [cmake] Fix build with ICU configured without collation support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-05 11:34 PST by Konstantin Tokarev
Modified: 2018-02-05 15:33 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2018-02-05 11:35 PST, Konstantin Tokarev
achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2018-02-05 11:34:51 PST
WebKit has CollatorDefault.cpp providing necessary stubs when UCONFIG_NO_COLLATION is defined, however it is not included in cmake file list.
Comment 1 Konstantin Tokarev 2018-02-05 11:35:48 PST
Created attachment 333105 [details]
Patch
Comment 2 WebKit Commit Bot 2018-02-05 15:23:55 PST
Comment on attachment 333105 [details]
Patch

Rejecting attachment 333105 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 333105, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/6372244
Comment 3 Konstantin Tokarev 2018-02-05 15:31:34 PST
Committed r228136: <https://trac.webkit.org/changeset/228136>
Comment 4 Radar WebKit Bug Importer 2018-02-05 15:33:28 PST
<rdar://problem/37252550>