Bug 182497 - [iOS] VideoFullscreenInterfaceAVKit should not ignore errors
Summary: [iOS] VideoFullscreenInterfaceAVKit should not ignore errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-05 11:28 PST by Eric Carlson
Modified: 2018-02-05 22:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (13.83 KB, patch)
2018-02-05 12:29 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-02-05 11:28:37 PST 
Don't ignore errors returned by -[AVPlayerViewController enterFullScreenAnimated:completionHandler:] or  -[AVPlayerViewController exitFullScreenAnimated:completionHandler:].
Comment 1 Eric Carlson 2018-02-05 11:29:15 PST 
<rdar://problem/36986898>
Comment 2 Eric Carlson 2018-02-05 12:29:24 PST 
Created attachment 333109 [details]
Patch
Comment 3 WebKit Commit Bot 2018-02-05 12:59:02 PST 
Comment on attachment 333109 [details]
Patch

Clearing flags on attachment: 333109

Committed r228115: <https://trac.webkit.org/changeset/228115>
Comment 4 WebKit Commit Bot 2018-02-05 12:59:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 John Wilander 2018-02-05 13:36:23 PST 
I'm fixing the iOS build.
Comment 6 John Wilander 2018-02-05 13:42:40 PST 
Build fix in r228119: <https://trac.webkit.org/changeset/228119>.