Bug 182487 - Initialize ImageBitmap::m_bitmapData in the constructor.
Summary: Initialize ImageBitmap::m_bitmapData in the constructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-05 07:59 PST by Ms2ger (he/him; ⌚ UTC+1/+2)
Modified: 2018-02-06 01:46 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.98 KB, patch)
2018-02-05 08:02 PST, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ms2ger (he/him; ⌚ UTC+1/+2) 2018-02-05 07:59:00 PST
.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-02-05 08:02:38 PST
Created attachment 333082 [details]
Patch
Comment 2 Sam Weinig 2018-02-05 11:55:24 PST
Comment on attachment 333082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333082&action=review

> Source/WebCore/html/ImageBitmap.cpp:-287
> -    // 7. Create a new ImageBitmap object.
> -
> -    auto imageBitmap = create();
> -

I like to leave a note when the steps change order, to indicate to future readers that the out of order numbers are intentional.
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-02-06 01:22:42 PST
Comment on attachment 333082 [details]
Patch

The spec is being reorganized in https://github.com/whatwg/html/pull/3424, so I'm just going to land this now, and check up on the numbering after.
Comment 4 WebKit Commit Bot 2018-02-06 01:45:53 PST
Comment on attachment 333082 [details]
Patch

Clearing flags on attachment: 333082

Committed r228153: <https://trac.webkit.org/changeset/228153>
Comment 5 WebKit Commit Bot 2018-02-06 01:45:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-06 01:46:30 PST
<rdar://problem/37267595>