WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182487
Initialize ImageBitmap::m_bitmapData in the constructor.
https://bugs.webkit.org/show_bug.cgi?id=182487
Summary
Initialize ImageBitmap::m_bitmapData in the constructor.
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported
2018-02-05 07:59:00 PST
.
Attachments
Patch
(6.98 KB, patch)
2018-02-05 08:02 PST
,
Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1
2018-02-05 08:02:38 PST
Created
attachment 333082
[details]
Patch
Sam Weinig
Comment 2
2018-02-05 11:55:24 PST
Comment on
attachment 333082
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=333082&action=review
> Source/WebCore/html/ImageBitmap.cpp:-287 > - // 7. Create a new ImageBitmap object. > - > - auto imageBitmap = create(); > -
I like to leave a note when the steps change order, to indicate to future readers that the out of order numbers are intentional.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3
2018-02-06 01:22:42 PST
Comment on
attachment 333082
[details]
Patch The spec is being reorganized in
https://github.com/whatwg/html/pull/3424
, so I'm just going to land this now, and check up on the numbering after.
WebKit Commit Bot
Comment 4
2018-02-06 01:45:53 PST
Comment on
attachment 333082
[details]
Patch Clearing flags on attachment: 333082 Committed
r228153
: <
https://trac.webkit.org/changeset/228153
>
WebKit Commit Bot
Comment 5
2018-02-06 01:45:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2018-02-06 01:46:30 PST
<
rdar://problem/37267595
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug