Bug 182478 - [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
Summary: [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency treegraph
Reported: 2018-02-05 03:09 PST by Yousuke Kimoto
Modified: 2018-02-05 18:31 PST (History)
4 users (show)

See Also:

Patch (5.70 KB, patch)
2018-02-05 04:08 PST, Yousuke Kimoto
no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2018-02-05 06:05 PST, Yousuke Kimoto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2018-02-05 03:09:12 PST
Currently wincairo port can be built on a WebKitLegacy build mode. This ticket aims establishing a WebKit build as well.

In this ticket, the following four issues will be fixed:

- WebKitLegacy and WebKit for WinCairo can be built at the same time.
- For TestWebKitAPI, sources related to WebKitLegacy are built at WebKit build. Those files should be referred for WebKitLegacy build.
- WebKit forwarding headers were not copied expectedly. The copying headers should use FLATTENED.
- The source directory of InjectedBundle for forwarding headers was typo  so that InjectedBundle public headers were not copied.

This ticket is not able to solve all the build issues for the wincairo webkit, so a lot of compiler errors will happen.
Wincairo webkit will be fixed such build errors in the near future.
Comment 1 Yousuke Kimoto 2018-02-05 04:08:26 PST
Created attachment 333073 [details]
Comment 2 Yousuke Kimoto 2018-02-05 06:05:48 PST
Created attachment 333078 [details]

To generate a build configuration for wincairo webkit,

> perl Tools/Scripts/build-webkit --no-ninja --64-bit --wincairo --generate-project-only --cmakeargs="
Comment 3 WebKit Commit Bot 2018-02-05 18:30:02 PST
Comment on attachment 333078 [details]

Clearing flags on attachment: 333078

Committed r228148: <https://trac.webkit.org/changeset/228148>
Comment 4 WebKit Commit Bot 2018-02-05 18:30:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-05 18:31:30 PST