WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
182466
[Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas()
https://bugs.webkit.org/show_bug.cgi?id=182466
Summary
[Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas()
Zan Dobersek
Reported
2018-02-04 01:36:49 PST
[Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas()
Attachments
Patch
(1.99 KB, patch)
2018-02-04 01:40 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2018-02-04 01:40:44 PST
Created
attachment 333049
[details]
Patch
Zan Dobersek
Comment 2
2018-02-04 23:38:11 PST
Comment on
attachment 333049
[details]
Patch Clearing flags on attachment: 333049 Committed
r228085
: <
https://trac.webkit.org/changeset/228085
>
Zan Dobersek
Comment 3
2018-02-04 23:38:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2018-02-04 23:39:24 PST
<
rdar://problem/37226268
>
Zan Dobersek
Comment 5
2018-02-05 02:19:00 PST
Reverted
r228085
for reason: Pixel data stride is imposed by OpenGL and shouldn't be adjusted for Cairo Committed
r228091
: <
https://trac.webkit.org/changeset/228091
>
Zan Dobersek
Comment 6
2018-02-05 02:24:45 PST
(In reply to Zan Dobersek from
comment #5
)
> Reverted
r228085
for reason: > > Pixel data stride is imposed by OpenGL and shouldn't be adjusted for Cairo >
I.e., this isn't data we're providing like we do in ImageBufferCairo, but instead it's data that's filled out by OpenGL via glReadPixels(), and that has the prescribed stride that matches width multiplied by 4 bytes (RGBA format, 1 byte per each component).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug