Bug 182464 - Web Inspector: Styles: completion popover doesn't hide when switching panels
Summary: Web Inspector: Styles: completion popover doesn't hide when switching panels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-03 20:13 PST by Nikita Vasilyev
Modified: 2018-02-07 11:01 PST (History)
4 users (show)

See Also:

Attachments
[Animated GIF] Bug (116.55 KB, image/gif)
2018-02-03 20:13 PST, Nikita Vasilyev 		no flags Details
Patch (4.32 KB, patch)
2018-02-05 19:08 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-02-03 20:13:11 PST 
Created attachment 333045 [details]
[Animated GIF] Bug

Steps:
1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/commenting-rules.html
2. Inspect the purple square.
3. Add a CSS new property by clicking after ".b {".
4. Type "font".
5. Switch to Computed panel.

Expected:
font's completion popover show hide.

Actual:
font's completion popover stays on screen.
Comment 1 Radar WebKit Bug Importer 2018-02-03 20:13:23 PST 
<rdar://problem/37202763>
Comment 2 Nikita Vasilyev 2018-02-03 20:15:24 PST 
The legacy styles sidebar has the same bug :(
Comment 3 Nikita Vasilyev 2018-02-05 19:08:27 PST 
Created attachment 333147 [details]
Patch

This is one way of fixing the bug. More generic fix would make CompletionSuggestionsView smarter.
Comment 4 WebKit Commit Bot 2018-02-07 11:01:21 PST 
Comment on attachment 333147 [details]
Patch

Clearing flags on attachment: 333147

Committed r228232: <https://trac.webkit.org/changeset/228232>
Comment 5 WebKit Commit Bot 2018-02-07 11:01:22 PST 
All reviewed patches have been landed.  Closing bug.