Bug 182461 - Web Inspector: Add an experimental setting to enable Sources tab
Summary: Web Inspector: Add an experimental setting to enable Sources tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-03 19:07 PST by Nikita Vasilyev
Modified: 2018-02-05 14:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2018-02-03 19:13 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (4.23 KB, patch)
2018-02-03 19:27 PST, Nikita Vasilyev 		bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2018-02-05 12:59 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-02-03 19:07:41 PST 
Add a new item to Settings -> Experimental.

    Sources: [ ] Replace Debugger and Resources tabs with Sources tab

<rdar://problem/37201455>
Comment 1 Nikita Vasilyev 2018-02-03 19:13:01 PST 
Created attachment 333041 [details]
Patch
Comment 2 Nikita Vasilyev 2018-02-03 19:27:47 PST 
Created attachment 333042 [details]
Patch
Comment 3 BJ Burg 2018-02-05 11:39:58 PST 
Comment on attachment 333042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333042&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:253
> +        experimentalSettingsView.addSetting(WI.UIString("Sources:"), WI.settings.experimentalEnableSourcesTab, WI.UIString("Replace Debugger and Resources tabs with Sources tab"));

Please just call it "Enable Sources Tab".
Comment 4 Nikita Vasilyev 2018-02-05 12:59:36 PST 
Created attachment 333113 [details]
Patch
Comment 5 WebKit Commit Bot 2018-02-05 14:37:57 PST 
Comment on attachment 333113 [details]
Patch

Clearing flags on attachment: 333113

Committed r228129: <https://trac.webkit.org/changeset/228129>
Comment 6 WebKit Commit Bot 2018-02-05 14:37:58 PST 
All reviewed patches have been landed.  Closing bug.