Should help us when looking at the register file of a crashlog.
<rdar://problem/37174236>
Created attachment 333015 [details] patch
Comment on attachment 333015 [details] patch r=me
Comment on attachment 333015 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=333015&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057 > + DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character); Is this an information leak in terms of privacy of the user? Given that it's just 2 characters, I think it's safe.
(In reply to Mark Lam from comment #4) > Comment on attachment 333015 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=333015&action=review > > r=me > > > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057 > > + DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character); > > Is this an information leak in terms of privacy of the user? Given that > it's just 2 characters, I think it's safe. Don't know, but let's not risk it. I'll remove it.
Created attachment 333017 [details] patch for landing
Comment on attachment 333017 [details] patch for landing Clearing flags on attachment: 333017 Committed r228035: <https://trac.webkit.org/changeset/228035>
All reviewed patches have been landed. Closing bug.