Bug 182453 – Make various DFG_ASSERTs provide more data to WTFCrashWithInfo

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Should help us when looking at the register file of a crashlog.

[Saam Barati]

<rdar://problem/37174236>

[Saam Barati]

Created attachment 333015 [details]
patch

[JF Bastien]

Comment on attachment 333015 [details]
patch

r=me

[Mark Lam]

Comment on attachment 333015 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333015&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057
> +                DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character);

Is this an information leak in terms of privacy of the user?  Given that it's just 2 characters, I think it's safe.

[Saam Barati]

(In reply to Mark Lam from comment #4)
> Comment on attachment 333015 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333015&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057
> > +                DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character);
> 
> Is this an information leak in terms of privacy of the user?  Given that
> it's just 2 characters, I think it's safe.

Don't know, but let's not risk it. I'll remove it.

[Saam Barati]

Created attachment 333017 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 333017 [details]
patch for landing

Clearing flags on attachment: 333017

Committed r228035: <https://trac.webkit.org/changeset/228035>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.