Bug 182453 - Make various DFG_ASSERTs provide more data to WTFCrashWithInfo
Summary: Make various DFG_ASSERTs provide more data to WTFCrashWithInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-02 15:16 PST by Saam Barati
Modified: 2018-02-02 16:43 PST (History)
13 users (show)

See Also:


Attachments
patch (36.39 KB, patch)
2018-02-02 16:06 PST, Saam Barati
jfbastien: review+
Details | Formatted Diff | Diff
patch for landing (35.83 KB, patch)
2018-02-02 16:12 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-02-02 15:16:45 PST
Should help us when looking at the register file of a crashlog.
Comment 1 Saam Barati 2018-02-02 16:03:48 PST
<rdar://problem/37174236>
Comment 2 Saam Barati 2018-02-02 16:06:25 PST
Created attachment 333015 [details]
patch
Comment 3 JF Bastien 2018-02-02 16:08:34 PST
Comment on attachment 333015 [details]
patch

r=me
Comment 4 Mark Lam 2018-02-02 16:10:07 PST
Comment on attachment 333015 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333015&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057
> +                DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character);

Is this an information leak in terms of privacy of the user?  Given that it's just 2 characters, I think it's safe.
Comment 5 Saam Barati 2018-02-02 16:10:33 PST
(In reply to Mark Lam from comment #4)
> Comment on attachment 333015 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333015&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057
> > +                DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character);
> 
> Is this an information leak in terms of privacy of the user?  Given that
> it's just 2 characters, I think it's safe.

Don't know, but let's not risk it. I'll remove it.
Comment 6 Saam Barati 2018-02-02 16:12:21 PST
Created attachment 333017 [details]
patch for landing
Comment 7 WebKit Commit Bot 2018-02-02 16:43:19 PST
Comment on attachment 333017 [details]
patch for landing

Clearing flags on attachment: 333017

Committed r228035: <https://trac.webkit.org/changeset/228035>
Comment 8 WebKit Commit Bot 2018-02-02 16:43:20 PST
All reviewed patches have been landed.  Closing bug.