Bug 182452 - JavaScriptCore files should not be included relatively
Summary: JavaScriptCore files should not be included relatively
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 182347
  Show dependency tree / graph
 
Reported: 2018-02-02 14:59 PST by Don Olmstead
Modified: 2018-02-05 11:04 PST (History)
10 users (show)

See Also:

Attachments
Patch (10.76 KB, patch)
2018-02-02 15:02 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-02-02 14:59:08 PST 
Within JavaScript core there are files that #include based on a relative path.
Comment 1 Don Olmstead 2018-02-02 15:02:02 PST 
Created attachment 333006 [details]
Patch

This removes all relative includes within JavaScriptCore headers.

There are explicit includes of <JavaScriptCore/Foo.h> within Source/JavaScriptCore/API that might be able to be removed at a later time. Its not clear if they would affect the Apple build or not with how frameworks are built. This should be revisited if CMake ports arrange their headers like Cocoa frameworks.
Comment 2 Keith Miller 2018-02-05 10:36:54 PST 
Comment on attachment 333006 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2018-02-05 11:02:11 PST 
Comment on attachment 333006 [details]
Patch

Clearing flags on attachment: 333006

Committed r228105: <https://trac.webkit.org/changeset/228105>
Comment 4 WebKit Commit Bot 2018-02-05 11:02:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-05 11:04:13 PST 
<rdar://problem/37243387>