WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182448
WebCore code generators should include JavaScriptCore headers directly
https://bugs.webkit.org/show_bug.cgi?id=182448
Summary
WebCore code generators should include JavaScriptCore headers directly
Don Olmstead
Reported
2018-02-02 12:58:26 PST
Currently the WebCore generators target WebCore/ForwardingHeaders rather than JavaScriptCore headers directly.
Attachments
Patch
(64.99 KB, patch)
2018-02-02 13:02 PST
,
Don Olmstead
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Don Olmstead
Comment 1
2018-02-02 13:02:43 PST
Created
attachment 332996
[details]
Patch Modified all includes to not target ForwardingHeaders. Tests were rebaselined.
Saam Barati
Comment 2
2018-02-02 14:54:50 PST
Comment on
attachment 332996
[details]
Patch Seems reasonable to me, but I'll leave the r+/comments for someone more experienced in the bindings generator
WebKit Commit Bot
Comment 3
2018-02-02 16:57:07 PST
Comment on
attachment 332996
[details]
Patch Clearing flags on attachment: 332996 Committed
r228038
: <
https://trac.webkit.org/changeset/228038
>
WebKit Commit Bot
Comment 4
2018-02-02 16:57:09 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2018-02-02 16:58:32 PST
<
rdar://problem/37176264
>
Joseph Pecoraro
Comment 6
2018-02-04 23:46:47 PST
It looks like this landed but it didn't actually remove the ForwardingHeaders directory. Can that directory be removed? =)
Joseph Pecoraro
Comment 7
2018-02-05 11:11:33 PST
(In reply to Joseph Pecoraro from
comment #6
)
> It looks like this landed but it didn't actually remove the > ForwardingHeaders directory. Can that directory be removed? =)
Oop, I thought this was the parent bug (because thats the link I clicked in my email)! Carry on!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug