Bug 182445 – JS Builtins should include JavaScriptCore headers directly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Don Olmstead]

Currently generate-js-builtins.py --framework WebCore generates includes that target the ForwardingHeaders directory rather than JavaScriptCore directly.

[Don Olmstead]

Created attachment 332988 [details]
Patch

Modifies the generator to output <JavaScriptCore/Foo.h> includes and updates the test expectations accordingly.

[EWS Watchlist]

This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)

[Yusuke Suzuki]

Comment on attachment 332988 [details]
Patch

r=me if all EWS gets green.

[Mark Lam]

Comment on attachment 332988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332988&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        (BuiltinsGenerator.model): Deleted.
> +        (BuiltinsGenerator.generate_output): Deleted.
> +        (BuiltinsGenerator.output_filename): Deleted.
> +        (BuiltinsGenerator.generate_license): Deleted.

I don't see these changes in the diff below.  Are these for real?

> Source/JavaScriptCore/ChangeLog:20
> +        (BuiltinsGenerator.generate_primary_header_includes): Deleted.
> +        (BuiltinsGenerator.generate_embedded_code_string_section_for_function): Deleted.
> +        (BuiltinsGenerator.wrap_with_guard): Deleted.
> +        (BuiltinsGenerator.mangledNameForObject): Deleted.
> +        (BuiltinsGenerator.mangledNameForObject.toCamel): Deleted.
> +        (BuiltinsGenerator.mangledNameForFunction): Deleted.
> +        (BuiltinsGenerator.mangledNameForFunction.toCamel): Deleted.

Ditto.

[Don Olmstead]

(In reply to Mark Lam from comment #4)
> Comment on attachment 332988 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332988&action=review
> 
> > Source/JavaScriptCore/ChangeLog:12
> > +        (BuiltinsGenerator.model): Deleted.
> > +        (BuiltinsGenerator.generate_output): Deleted.
> > +        (BuiltinsGenerator.output_filename): Deleted.
> > +        (BuiltinsGenerator.generate_license): Deleted.
> 
> I don't see these changes in the diff below.  Are these for real?
> 
> > Source/JavaScriptCore/ChangeLog:20
> > +        (BuiltinsGenerator.generate_primary_header_includes): Deleted.
> > +        (BuiltinsGenerator.generate_embedded_code_string_section_for_function): Deleted.
> > +        (BuiltinsGenerator.wrap_with_guard): Deleted.
> > +        (BuiltinsGenerator.mangledNameForObject): Deleted.
> > +        (BuiltinsGenerator.mangledNameForObject.toCamel): Deleted.
> > +        (BuiltinsGenerator.mangledNameForFunction): Deleted.
> > +        (BuiltinsGenerator.mangledNameForFunction.toCamel): Deleted.
> 
> Ditto.

I'll go ahead and fix up the Changelog.

[Don Olmstead]

Created attachment 332994 [details]
Patch

Fix the Changelog up manually

[WebKit Commit Bot]

Comment on attachment 332994 [details]
Patch

Clearing flags on attachment: 332994

Committed r228032: <https://trac.webkit.org/changeset/228032>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37173468>

[Ryan Haddad]

Rebaselined bindings generator tests in https://trac.webkit.org/r228040