Bug 182445 - JS Builtins should include JavaScriptCore headers directly
Summary: JS Builtins should include JavaScriptCore headers directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 182347
  Show dependency treegraph
 
Reported: 2018-02-02 11:56 PST by Don Olmstead
Modified: 2018-02-02 17:39 PST (History)
11 users (show)

See Also:


Attachments
Patch (12.19 KB, patch)
2018-02-02 11:58 PST, Don Olmstead
ysuzuki: review+
Details | Formatted Diff | Diff
Patch (11.45 KB, patch)
2018-02-02 12:41 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-02-02 11:56:34 PST
Currently generate-js-builtins.py --framework WebCore generates includes that target the ForwardingHeaders directory rather than JavaScriptCore directly.
Comment 1 Don Olmstead 2018-02-02 11:58:09 PST
Created attachment 332988 [details]
Patch

Modifies the generator to output <JavaScriptCore/Foo.h> includes and updates the test expectations accordingly.
Comment 2 Build Bot 2018-02-02 12:00:55 PST
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Comment 3 Yusuke Suzuki 2018-02-02 12:30:44 PST
Comment on attachment 332988 [details]
Patch

r=me if all EWS gets green.
Comment 4 Mark Lam 2018-02-02 12:33:37 PST
Comment on attachment 332988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332988&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        (BuiltinsGenerator.model): Deleted.
> +        (BuiltinsGenerator.generate_output): Deleted.
> +        (BuiltinsGenerator.output_filename): Deleted.
> +        (BuiltinsGenerator.generate_license): Deleted.

I don't see these changes in the diff below.  Are these for real?

> Source/JavaScriptCore/ChangeLog:20
> +        (BuiltinsGenerator.generate_primary_header_includes): Deleted.
> +        (BuiltinsGenerator.generate_embedded_code_string_section_for_function): Deleted.
> +        (BuiltinsGenerator.wrap_with_guard): Deleted.
> +        (BuiltinsGenerator.mangledNameForObject): Deleted.
> +        (BuiltinsGenerator.mangledNameForObject.toCamel): Deleted.
> +        (BuiltinsGenerator.mangledNameForFunction): Deleted.
> +        (BuiltinsGenerator.mangledNameForFunction.toCamel): Deleted.

Ditto.
Comment 5 Don Olmstead 2018-02-02 12:36:15 PST
(In reply to Mark Lam from comment #4)
> Comment on attachment 332988 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332988&action=review
> 
> > Source/JavaScriptCore/ChangeLog:12
> > +        (BuiltinsGenerator.model): Deleted.
> > +        (BuiltinsGenerator.generate_output): Deleted.
> > +        (BuiltinsGenerator.output_filename): Deleted.
> > +        (BuiltinsGenerator.generate_license): Deleted.
> 
> I don't see these changes in the diff below.  Are these for real?
> 
> > Source/JavaScriptCore/ChangeLog:20
> > +        (BuiltinsGenerator.generate_primary_header_includes): Deleted.
> > +        (BuiltinsGenerator.generate_embedded_code_string_section_for_function): Deleted.
> > +        (BuiltinsGenerator.wrap_with_guard): Deleted.
> > +        (BuiltinsGenerator.mangledNameForObject): Deleted.
> > +        (BuiltinsGenerator.mangledNameForObject.toCamel): Deleted.
> > +        (BuiltinsGenerator.mangledNameForFunction): Deleted.
> > +        (BuiltinsGenerator.mangledNameForFunction.toCamel): Deleted.
> 
> Ditto.

I'll go ahead and fix up the Changelog.
Comment 6 Don Olmstead 2018-02-02 12:41:02 PST
Created attachment 332994 [details]
Patch

Fix the Changelog up manually
Comment 7 WebKit Commit Bot 2018-02-02 15:37:16 PST
Comment on attachment 332994 [details]
Patch

Clearing flags on attachment: 332994

Committed r228032: <https://trac.webkit.org/changeset/228032>
Comment 8 WebKit Commit Bot 2018-02-02 15:37:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-02-02 15:38:37 PST
<rdar://problem/37173468>
Comment 10 Ryan Haddad 2018-02-02 17:39:33 PST
Rebaselined bindings generator tests in https://trac.webkit.org/r228040