Bug 182441 - More ARM64_32 fixes.
Summary: More ARM64_32 fixes.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2018-02-02 10:58 PST by Mark Lam
Modified: 2018-02-02 12:25 PST (History)
10 users (show)

See Also:

proposed patch. (4.26 KB, patch)
2018-02-02 11:06 PST, Mark Lam
mitz: review+
Details | Formatted Diff | Diff
patch for landing. (4.29 KB, patch)
2018-02-02 11:16 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-02-02 10:58:38 PST
My previous speculative ARM64_32 build fix in copyLCharsFromUCharSource() was wrong.  I've now fixed it to use choose the default case instead of the ARM64 case if the target is ARM64_32.

I also disabled more dynamicPoisoning code in ARM64_32.  This code assumes a 64-bit pointer which is not applicable here.
Comment 1 Radar WebKit Bug Importer 2018-02-02 11:00:43 PST
Comment 2 Mark Lam 2018-02-02 11:06:36 PST
Created attachment 332982 [details]
proposed patch.
Comment 3 Mark Lam 2018-02-02 11:16:54 PST
Created attachment 332985 [details]
patch for landing.
Comment 4 Mark Lam 2018-02-02 12:25:21 PST
Thanks for the review.  Landed in r228022: <http://trac.webkit.org/r228022>.