Bug 182438 - [Modern Media Controls] Turn media/modern-media-controls/volume-* back on
Summary: [Modern Media Controls] Turn media/modern-media-controls/volume-* back on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-02 09:29 PST by Antoine Quint
Modified: 2018-02-05 14:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (24.07 KB, patch)
2018-02-02 09:31 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-02 09:29:35 PST 
[Modern Media Controls] Turn media/modern-media-controls/volume-* back on
Comment 1 Antoine Quint 2018-02-02 09:31:01 PST 
Created attachment 332975 [details]
Patch
Comment 2 Antoine Quint 2018-02-02 10:51:46 PST 
Committed r228017: <https://trac.webkit.org/changeset/228017>
Comment 3 Radar WebKit Bug Importer 2018-02-02 10:53:26 PST 
<rdar://problem/37161800>
Comment 4 Matt Lewis 2018-02-05 14:54:07 PST 
One of the tests media/modern-media-controls/slider/slider-value.html turned back on is still very flaky

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fslider%2Fslider-value.html

Build:
https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r228109%20(2239)/results.html
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/builds/2239

Diff:
--- /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/slider/slider-value-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/slider/slider-value-actual.txt
@@ -32,4 +32,5 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
+controlValueDidChange, value = 0.148