Bug 182421 - [Extra Zoom Mode] Implement support for indirect mainframe scrolling
Summary: [Extra Zoom Mode] Implement support for indirect mainframe scrolling
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2018-02-01 22:56 PST by Wenson Hsieh
Modified: 2018-02-02 09:49 PST (History)
3 users (show)

See Also:

Patch (3.64 KB, patch)
2018-02-01 23:14 PST, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
ChangeLog tweak (3.65 KB, patch)
2018-02-02 07:37 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-02-01 22:56:28 PST
Comment 1 Wenson Hsieh 2018-02-01 23:14:59 PST
Created attachment 332943 [details]
Comment 2 Wenson Hsieh 2018-02-02 07:33:58 PST
Comment on attachment 332943 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=332943&action=review

Thanks for the review!

> Source/WebKit/ChangeLog:26
> +        -initWithFrame:, and (2) even if we set the -enabled to NO, UIKit resets it to YES in the future.

"…in the future" sounds a bit awkward, I'm going to tweak this ChangeLog wording here before I land.
Comment 3 Wenson Hsieh 2018-02-02 07:37:02 PST
Created attachment 332966 [details]
ChangeLog tweak
Comment 4 WebKit Commit Bot 2018-02-02 09:44:40 PST
Comment on attachment 332966 [details]
ChangeLog tweak

Clearing flags on attachment: 332966

Committed r228016: <https://trac.webkit.org/changeset/228016>