Bug 182415 - Make MallocBench easier for non-WebKit engineers to run
Summary: Make MallocBench easier for non-WebKit engineers to run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-01 17:10 PST by Geoffrey Garen
Modified: 2018-02-02 12:31 PST (History)
7 users (show)

See Also:


Attachments
Patch (8.63 KB, patch)
2018-02-01 17:33 PST, Geoffrey Garen
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2018-02-01 17:10:56 PST
Make MallocBench easier for non-WebKit engineers to run
Comment 1 Geoffrey Garen 2018-02-01 17:33:25 PST
Created attachment 332925 [details]
Patch
Comment 2 Saam Barati 2018-02-01 17:37:51 PST
Comment on attachment 332925 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2018-02-01 19:14:10 PST
Comment on attachment 332925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332925&action=review

Looks good to me too.

> PerformanceTests/MallocBench/run-malloc-benchmarks:259
> +        name = arg.split(":")[0]
> +        path = arg.split(":")[1]

You can write this in a way that avoids split twice:

    name, path = arg.split(":")
Comment 4 Geoffrey Garen 2018-02-02 12:30:25 PST
Committed r228023: <https://trac.webkit.org/changeset/228023>
Comment 5 Radar WebKit Bug Importer 2018-02-02 12:31:31 PST
<rdar://problem/37166033>