Bug 182412 - Form submission after navigation fails when decidePolicyForNavigationAction is async
Summary: Form submission after navigation fails when decidePolicyForNavigationAction i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 182697
Blocks:
  Show dependency tree / graph
 
Reported: 2018-02-01 16:43 PST by Alex Christensen
Modified: 2018-02-12 16:33 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2018-02-01 16:44 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (5.58 KB, patch)
2018-02-02 14:18 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (368.35 KB, application/zip)
2018-02-02 14:59 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews113 for mac-sierra (380.47 KB, application/zip)
2018-02-02 15:09 PST, EWS Watchlist 		no flags Details
Patch (8.57 KB, patch)
2018-02-02 15:15 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (498.56 KB, application/zip)
2018-02-02 15:42 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews112 for mac-sierra (1.25 MB, application/zip)
2018-02-02 15:56 PST, EWS Watchlist 		no flags Details
Patch (5.12 KB, patch)
2018-02-08 13:59 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-02-01 16:43:00 PST 
Form submission after navigation fails when decidePolicyForNavigationAction is async
Comment 1 Alex Christensen 2018-02-01 16:44:08 PST 
Created attachment 332923 [details]
Patch
Comment 2 Alex Christensen 2018-02-01 16:44:44 PST 
Comment on attachment 332923 [details]
Patch

Initial patch just contains failing test for rdar://problem/35181099
Comment 3 Alex Christensen 2018-02-02 14:18:12 PST 
Created attachment 333000 [details]
Patch
Comment 4 Brady Eidson 2018-02-02 14:28:33 PST 
Comment on attachment 333000 [details]
Patch

As discussed in person, this still has changed WK API behavior.
Comment 5 EWS Watchlist 2018-02-02 14:58:59 PST 
Comment on attachment 333000 [details]
Patch

Attachment 333000 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6337129

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2018-02-02 14:59:00 PST 
Created attachment 333005 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-02-02 15:09:25 PST 
Comment on attachment 333000 [details]
Patch

Attachment 333000 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6337119

Number of test failures exceeded the failure limit.
Comment 8 EWS Watchlist 2018-02-02 15:09:26 PST 
Created attachment 333007 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Alex Christensen 2018-02-02 15:15:17 PST 
Created attachment 333009 [details]
Patch
Comment 10 EWS Watchlist 2018-02-02 15:42:14 PST 
Comment on attachment 333009 [details]
Patch

Attachment 333009 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6337744

Number of test failures exceeded the failure limit.
Comment 11 EWS Watchlist 2018-02-02 15:42:15 PST 
Created attachment 333010 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 EWS Watchlist 2018-02-02 15:56:20 PST 
Comment on attachment 333009 [details]
Patch

Attachment 333009 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6337743

Number of test failures exceeded the failure limit.
Comment 13 EWS Watchlist 2018-02-02 15:56:21 PST 
Created attachment 333013 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 14 Alex Christensen 2018-02-08 12:57:26 PST 
Chris, the three WPT test failures in my latest patch are definitely related to why this bug is happening.  If you make TestController::decidePolicyForNavigationAction always dispatch on the run loop, you'll be able to investigate them.  I think fixing this will take adding a queue of some sort to the FrameLoader.
Comment 15 Chris Dumez 2018-02-08 13:58:29 PST 
<rdar://problem/35181099>
Comment 16 Chris Dumez 2018-02-08 13:59:09 PST 
Created attachment 333421 [details]
Patch
Comment 17 Chris Dumez 2018-02-08 13:59:43 PST 
Seems to pass the tests locally and fix the bug. Let's see how EWS likes it.
Comment 18 Chris Dumez 2018-02-08 14:59:50 PST 
Comment on attachment 333421 [details]
Patch

API tests locally look happy. Mac-EWS as well.
Comment 19 WebKit Commit Bot 2018-02-08 15:49:21 PST 
Comment on attachment 333421 [details]
Patch

Clearing flags on attachment: 333421

Committed r228299: <https://trac.webkit.org/changeset/228299>
Comment 20 WebKit Commit Bot 2018-02-08 15:49:23 PST 
All reviewed patches have been landed.  Closing bug.