Bug 182408 - Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies
Summary: Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-01 15:24 PST by Brent Fulgham
Modified: 2018-02-01 16:54 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.28 KB, patch)
2018-02-01 15:29 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch for landing (3.38 KB, patch)
2018-02-01 15:45 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-02-01 15:24:42 PST
Our debug logging is not including the results for some resource loads because they are being blocked (not just partitioned).

Revise the logging so that blocked loads are properly captured for testing.
Comment 1 Brent Fulgham 2018-02-01 15:29:37 PST
Created attachment 332915 [details]
Patch
Comment 2 Chris Dumez 2018-02-01 15:42:46 PST
Comment on attachment 332915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>      auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID());

Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method?

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
> +        s.replace('\\', "\\\\").replace('"', "\\\"");

return s.replace('\\', "\\\\").replace('"', "\\\"");
Comment 3 Brent Fulgham 2018-02-01 15:44:48 PST
Comment on attachment 332915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>>      auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID());
> 
> Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method?

Will do!

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
>> +        s.replace('\\', "\\\\").replace('"', "\\\"");
> 
> return s.replace('\\', "\\\\").replace('"', "\\\"");

Will do.
Comment 4 Brent Fulgham 2018-02-01 15:45:46 PST
Created attachment 332917 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-02-01 16:54:48 PST
Comment on attachment 332917 [details]
Patch for landing

Clearing flags on attachment: 332917

Committed r227991: <https://trac.webkit.org/changeset/227991>
Comment 6 WebKit Commit Bot 2018-02-01 16:54:50 PST
All reviewed patches have been landed.  Closing bug.