RESOLVED FIXED 182408
Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies 
https://bugs.webkit.org/show_bug.cgi?id=182408
Summary Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies
Brent Fulgham
Reported 2018-02-01 15:24:42 PST
Our debug logging is not including the results for some resource loads because they are being blocked (not just partitioned). Revise the logging so that blocked loads are properly captured for testing.
Attachments
Patch (3.28 KB, patch)
2018-02-01 15:29 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.38 KB, patch)
2018-02-01 15:45 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-02-01 15:29:37 PST
Created attachment 332915 [details] Patch
Chris Dumez
Comment 2 2018-02-01 15:42:46 PST
Comment on attachment 332915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720 > auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID()); Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method? > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727 > + s.replace('\\', "\\\\").replace('"', "\\\""); return s.replace('\\', "\\\\").replace('"', "\\\"");
Brent Fulgham
Comment 3 2018-02-01 15:44:48 PST
Comment on attachment 332915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review >> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720 >> auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID()); > > Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method? Will do! >> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727 >> + s.replace('\\', "\\\\").replace('"', "\\\""); > > return s.replace('\\', "\\\\").replace('"', "\\\""); Will do.
Brent Fulgham
Comment 4 2018-02-01 15:45:46 PST
Created attachment 332917 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-02-01 16:54:48 PST
Comment on attachment 332917 [details] Patch for landing Clearing flags on attachment: 332917 Committed r227991: <https://trac.webkit.org/changeset/227991>
WebKit Commit Bot
Comment 6 2018-02-01 16:54:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.