Bug 182407 - Clearing all service worker registrations should wait for importing service worker registration to finish
Summary: Clearing all service worker registrations should wait for importing service w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-01 14:58 PST by youenn fablet
Modified: 2018-02-02 16:39 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2018-02-01 14:59 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.33 KB, patch)
2018-02-01 18:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Follow-up fix (1.66 KB, patch)
2018-02-02 15:51 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-02-01 14:58:19 PST 
Otherwise, there might be some left over.
Comment 1 youenn fablet 2018-02-01 14:59:39 PST 
Created attachment 332911 [details]
Patch
Comment 2 Chris Dumez 2018-02-01 15:06:31 PST 
Comment on attachment 332911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332911&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:187
> +void SWServer::clearAll(CompletionHandler<void()>&& completionHandler)

2 concerns:
- what about clear(origin)?
- I do not see why we could not get several clearAll() requests consecutively, in which case, you would keep overwriting m_clearAllCompletionHandler.
Comment 3 youenn fablet 2018-02-01 18:09:53 PST 
Created attachment 332928 [details]
Patch
Comment 4 WebKit Commit Bot 2018-02-02 13:09:02 PST 
Comment on attachment 332928 [details]
Patch

Clearing flags on attachment: 332928

Committed r228025: <https://trac.webkit.org/changeset/228025>
Comment 5 WebKit Commit Bot 2018-02-02 13:09:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-02 13:11:01 PST 
<rdar://problem/37167523>
Comment 7 youenn fablet 2018-02-02 15:51:44 PST 
Reopening to attach new patch.
Comment 8 youenn fablet 2018-02-02 15:51:45 PST 
Created attachment 333012 [details]
Follow-up fix
Comment 9 WebKit Commit Bot 2018-02-02 16:39:36 PST 
Comment on attachment 333012 [details]
Follow-up fix

Clearing flags on attachment: 333012

Committed r228034: <https://trac.webkit.org/changeset/228034>
Comment 10 WebKit Commit Bot 2018-02-02 16:39:38 PST 
All reviewed patches have been landed.  Closing bug.