RESOLVED FIXED 182374
[RenderTreeBuilder] Move RenderTableRow::collapseAndDestroyAnonymousSiblingRows to RenderTreeBuilder 
https://bugs.webkit.org/show_bug.cgi?id=182374
Summary [RenderTreeBuilder] Move RenderTableRow::collapseAndDestroyAnonymousSiblingRo...
zalan
Reported 2018-01-31 20:49:49 PST
it's only called from RenderTreeBuilder
Attachments
Patch (6.74 KB, patch)
2018-01-31 20:53 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2018-02-01 07:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-31 20:50:10 PST
<rdar://problem/37102005>
zalan
Comment 2 2018-01-31 20:53:08 PST
Created attachment 332846 [details] Patch
Antti Koivisto
Comment 3 2018-02-01 01:07:34 PST
Comment on attachment 332846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332846&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:370 > +void RenderTreeBuilder::collapseAndDestroyAnonymousSiblingRows(RenderTableRow& row) Shouldn't this go to Table?
zalan
Comment 4 2018-02-01 07:28:02 PST
Created attachment 332876 [details] Patch
zalan
Comment 5 2018-02-01 07:28:51 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 332846 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332846&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:370 > > +void RenderTreeBuilder::collapseAndDestroyAnonymousSiblingRows(RenderTableRow& row) > > Shouldn't this go to Table? Absolutely!
WebKit Commit Bot
Comment 6 2018-02-01 07:52:38 PST
Comment on attachment 332876 [details] Patch Clearing flags on attachment: 332876 Committed r227963: <https://trac.webkit.org/changeset/227963>
WebKit Commit Bot
Comment 7 2018-02-01 07:52:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.