Bug 182374 - [RenderTreeBuilder] Move RenderTableRow::collapseAndDestroyAnonymousSiblingRows to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderTableRow::collapseAndDestroyAnonymousSiblingRo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-31 20:49 PST by zalan
Modified: 2018-02-01 07:52 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.74 KB, patch)
2018-01-31 20:53 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2018-02-01 07:28 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-31 20:49:49 PST
it's only called from RenderTreeBuilder
Comment 1 Radar WebKit Bug Importer 2018-01-31 20:50:10 PST
<rdar://problem/37102005>
Comment 2 zalan 2018-01-31 20:53:08 PST
Created attachment 332846 [details]
Patch
Comment 3 Antti Koivisto 2018-02-01 01:07:34 PST
Comment on attachment 332846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332846&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:370
> +void RenderTreeBuilder::collapseAndDestroyAnonymousSiblingRows(RenderTableRow& row)

Shouldn't this go to Table?
Comment 4 zalan 2018-02-01 07:28:02 PST
Created attachment 332876 [details]
Patch
Comment 5 zalan 2018-02-01 07:28:51 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 332846 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332846&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:370
> > +void RenderTreeBuilder::collapseAndDestroyAnonymousSiblingRows(RenderTableRow& row)
> 
> Shouldn't this go to Table?
Absolutely!
Comment 6 WebKit Commit Bot 2018-02-01 07:52:38 PST
Comment on attachment 332876 [details]
Patch

Clearing flags on attachment: 332876

Committed r227963: <https://trac.webkit.org/changeset/227963>
Comment 7 WebKit Commit Bot 2018-02-01 07:52:40 PST
All reviewed patches have been landed.  Closing bug.