Bug 182372 - Queue a microtask when a waitUntil() promise is settled
Summary: Queue a microtask when a waitUntil() promise is settled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://w3c.github.io/ServiceWorker/#...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-31 20:11 PST by Chris Dumez
Modified: 2018-02-01 03:50 PST (History)
11 users (show)

See Also:

Attachments
Patch (8.09 KB, patch)
2018-01-31 20:43 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.61 MB, application/zip)
2018-01-31 21:58 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-01-31 20:11:24 PST 
Queue a microtask when a waitUntil() promise is settled, as per:
- https://w3c.github.io/ServiceWorker/#dom-extendableevent-waituntil (step 5)

Otherwise, we decrement m_pendingPromiseCount too quickly and it may cause following calls to waitUntil() to throw when they shouldn't.
Comment 1 Radar WebKit Bug Importer 2018-01-31 20:11:51 PST 
<rdar://problem/37101019>
Comment 2 Chris Dumez 2018-01-31 20:43:01 PST 
Created attachment 332844 [details]
Patch
Comment 3 Mark Lam 2018-01-31 20:57:57 PST 
Comment on attachment 332844 [details]
Patch

r=me
Comment 4 EWS Watchlist 2018-01-31 21:58:53 PST 
Comment on attachment 332844 [details]
Patch

Attachment 332844 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6310810

New failing tests:
js/regexp-unicode.html
Comment 5 EWS Watchlist 2018-01-31 21:58:54 PST 
Created attachment 332848 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 WebKit Commit Bot 2018-02-01 03:50:52 PST 
Comment on attachment 332844 [details]
Patch

Clearing flags on attachment: 332844

Committed r227959: <https://trac.webkit.org/changeset/227959>
Comment 7 WebKit Commit Bot 2018-02-01 03:50:54 PST 
All reviewed patches have been landed.  Closing bug.