fast/forms/ios/ipad/select-form-run-twice.html should wait for it's promise to be fulfilled before finishing the test. If it does not, the subsequent test may crash.
Created attachment 332830 [details] Patch
<rdar://problem/37098169>
Comment on attachment 332830 [details] Patch We need to go through and audit layout tests for outstanding promises when the test ends. I will not have time to do this thoroughly in the next few weeks, before I do the audit, I've asked the bot watchers to send me these sorts of test failures as they are found. This is another one of them.
Comment on attachment 332830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332830&action=review > LayoutTests/fast/forms/ios/ipad/select-form-run-twice.html:37 > + Promise.all(promises).then(function() { `promises` is empty when we Promise.all here, so wouldn't this just resolve on the next runloop?
Comment on attachment 332830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332830&action=review >> LayoutTests/fast/forms/ios/ipad/select-form-run-twice.html:37 >> + Promise.all(promises).then(function() { > > `promises` is empty when we Promise.all here, so wouldn't this just resolve on the next runloop? For some reason I had thought that the other js functions had run already, but you are correct. I'll re-work this change.
Created attachment 332924 [details] Patch
Comment on attachment 332924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332924&action=review > LayoutTests/ChangeLog:8 > + Multiple potential button clicked, due to looping function calls can cause threads to be running in the next I think you grammared here. Threads?
https://trac.webkit.org/r227992