Bug 182362 - Use different debug red colors for different contexts
Summary: Use different debug red colors for different contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-31 16:47 PST by Simon Fraser (smfr)
Modified: 2018-01-31 23:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.52 KB, patch)
2018-01-31 16:49 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2018-01-31 16:55 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-01-31 16:47:38 PST
Use different debug red colors for different contexts
Comment 1 Simon Fraser (smfr) 2018-01-31 16:49:48 PST
Created attachment 332823 [details]
Patch
Comment 2 Tim Horton 2018-01-31 16:54:10 PST
Comment on attachment 332823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332823&action=review

> Source/WebCore/page/FrameView.cpp:4023
> -    if (!renderView) {
> +    if (renderView) {

!?
Comment 3 Simon Fraser (smfr) 2018-01-31 16:55:05 PST
Created attachment 332824 [details]
Patch
Comment 4 WebKit Commit Bot 2018-01-31 23:28:15 PST
Comment on attachment 332824 [details]
Patch

Clearing flags on attachment: 332824

Committed r227954: <https://trac.webkit.org/changeset/227954>
Comment 5 WebKit Commit Bot 2018-01-31 23:28:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-31 23:29:21 PST
<rdar://problem/37105147>