Bug 182351 - Add a release assertion to ensure timers are deleted in the right thread
Summary: Add a release assertion to ensure timers are deleted in the right thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-31 14:08 PST by Ryosuke Niwa
Modified: 2018-01-31 16:22 PST (History)
6 users (show)

See Also:


Attachments
Adds a release assertion (1.98 KB, patch)
2018-01-31 14:12 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-01-31 14:08:28 PST
Add a releaser assert in ~Timer to make sure a timer gets constructed & destructed in the same thread.
Comment 1 Ryosuke Niwa 2018-01-31 14:12:09 PST
Created attachment 332801 [details]
Adds a release assertion
Comment 2 Radar WebKit Bug Importer 2018-01-31 14:12:38 PST
<rdar://problem/37086376>
Comment 3 David Kilzer (:ddkilzer) 2018-01-31 14:18:43 PST
Comment on attachment 332801 [details]
Adds a release assertion

r=me if EWS is happy
Comment 4 WebKit Commit Bot 2018-01-31 15:08:49 PST
Comment on attachment 332801 [details]
Adds a release assertion

Clearing flags on attachment: 332801

Committed r227934: <https://trac.webkit.org/changeset/227934>
Comment 5 WebKit Commit Bot 2018-01-31 15:08:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2018-01-31 16:22:01 PST
Good change, I wasted time earlier this week trying to guess whether this might be occurring in another bug. (It wasn't, but I didn't have an easy way to know that.)