Bug 182348 - [RenderTreeBuilder] Move RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers to RenderTreeBuilder.
Summary: [RenderTreeBuilder] Move RenderObject::removeFromParentAndDestroyCleaningUpAn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-31 13:00 PST by zalan
Modified: 2018-01-31 14:00 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.95 KB, patch)
2018-01-31 13:12 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-31 13:00:40 PST
All the callsites are in the updater
Comment 1 Radar WebKit Bug Importer 2018-01-31 13:01:31 PST
<rdar://problem/37082837>
Comment 2 zalan 2018-01-31 13:12:01 PST
Created attachment 332797 [details]
Patch
Comment 3 Antti Koivisto 2018-01-31 13:20:59 PST
Comment on attachment 332797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332797&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:554
> +                RenderTreeBuilder::current()->removeFromParentAndDestroyCleaningUpAnonymousWrappers(*renderer);

These call sites should be non-static functions
Comment 4 WebKit Commit Bot 2018-01-31 14:00:20 PST
Comment on attachment 332797 [details]
Patch

Clearing flags on attachment: 332797

Committed r227928: <https://trac.webkit.org/changeset/227928>
Comment 5 WebKit Commit Bot 2018-01-31 14:00:22 PST
All reviewed patches have been landed.  Closing bug.