Add libmount to WPE dependencies
Created attachment 332787 [details] Patch Add libmount deps
Probably worth a review from someone who uses Arch Linux. I wasn't 100% confident about the package name, but I did find this, https://www.archlinux.org/packages/core/x86_64/libutil-linux/ Which says the libmount library is included in that package.
Comment on attachment 332787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332787&action=review Arch Linux user here (hi!) > Tools/wpe/install-dependencies:207 > + libutil-linux \ Here you want “util-linux” instead: the “libutil-linux” only includes the dynamic libraries, but the headers and .pc files for pkg-config are part of “util-linux”. Also, installing “util-linux” causes both packages to be installed due to package dependencies. TL;DR: Change this to “util-linux”, please.
Created attachment 332796 [details] Patch Thank you Adrian! I'll send this to commit queue with your blessings
Created attachment 332862 [details] Patch for landing
Comment on attachment 332862 [details] Patch for landing Rejecting attachment 332862 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 332862, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6315512
Created attachment 332961 [details] Patch Rebase
Created attachment 332962 [details] Patch for landing
Comment on attachment 332962 [details] Patch for landing Rejecting attachment 332962 [details] from commit-queue. New failing tests: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html Full output: http://webkit-queues.webkit.org/results/6336803
Created attachment 333003 [details] Archive of layout-test-results from webkit-cq-01 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-sierra Platform: Mac OS X 10.12.6
Why is this patch getting rejecting for failing a MAC PORT test?
(In reply to Charlie Turner from comment #11) > Why is this patch getting rejecting for failing a MAC PORT test? commit-queue is a Mac bot that runs the tests before committing. Flaky tests like this one defeat it.
Comment on attachment 332962 [details] Patch for landing Clearing flags on attachment: 332962 Committed r228048: <https://trac.webkit.org/changeset/228048>
All reviewed patches have been landed. Closing bug.