Bug 182338 - [Modern Media Controls] Turn media/modern-media-controls/macos-inline-media-controls back on
Summary: [Modern Media Controls] Turn media/modern-media-controls/macos-inline-media-c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-31 09:40 PST by Antoine Quint
Modified: 2018-01-31 23:13 PST (History)
3 users (show)

See Also:

Attachments
Patch (58.30 KB, patch)
2018-01-31 09:42 PST, Antoine Quint 		eric.carlson: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-01-31 09:40:41 PST 
[Modern Media Controls] Turn media/modern-media-controls/macos-inline-media-controls back on
Comment 1 Antoine Quint 2018-01-31 09:42:48 PST 
Created attachment 332770 [details]
Patch
Comment 2 WebKit Commit Bot 2018-01-31 15:24:15 PST 
Comment on attachment 332770 [details]
Patch

Rejecting attachment 332770 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 332770, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/6302591
Comment 3 Antoine Quint 2018-01-31 23:12:16 PST 
Committed r227953: <https://trac.webkit.org/changeset/227953>
Comment 4 Radar WebKit Bug Importer 2018-01-31 23:13:22 PST 
<rdar://problem/37104606>