Bug 182313 - Clients should register to StorageProcess with their service worker registration identifier
Summary: Clients should register to StorageProcess with their service worker registrat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 183274
Blocks:
  Show dependency tree / graph
 
Reported: 2018-01-30 15:24 PST by youenn fablet
Modified: 2018-03-02 11:17 PST (History)
7 users (show)

See Also:

Attachments
Patch (20.35 KB, patch)
2018-01-30 16:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (20.40 KB, patch)
2018-02-28 16:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (20.15 KB, patch)
2018-03-01 15:11 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing matchAll (20.80 KB, patch)
2018-03-02 08:21 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-01-30 15:24:15 PST 
Currently, they are doing so using service worker identifier which might change.
Comment 1 youenn fablet 2018-01-30 16:44:23 PST 
Created attachment 332723 [details]
Patch
Comment 2 youenn fablet 2018-02-28 16:44:13 PST 
Created attachment 334785 [details]
Patch
Comment 3 Chris Dumez 2018-03-01 15:03:11 PST 
Comment on attachment 334785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334785&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:308
> +    // NOOPFor each service worker client who is using registration:

typo
Comment 4 youenn fablet 2018-03-01 15:11:55 PST 
Created attachment 334859 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-03-01 16:04:10 PST 
Comment on attachment 334859 [details]
Patch for landing

Clearing flags on attachment: 334859

Committed r229153: <https://trac.webkit.org/changeset/229153>
Comment 6 WebKit Commit Bot 2018-03-01 16:04:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-03-01 16:06:00 PST 
<rdar://problem/38044403>
Comment 8 WebKit Commit Bot 2018-03-01 22:00:50 PST 
Re-opened since this is blocked by bug 183274
Comment 9 youenn fablet 2018-03-02 08:21:47 PST 
Created attachment 334898 [details]
Fixing matchAll
Comment 10 WebKit Commit Bot 2018-03-02 11:17:07 PST 
Comment on attachment 334898 [details]
Fixing matchAll

Clearing flags on attachment: 334898

Committed r229183: <https://trac.webkit.org/changeset/229183>
Comment 11 WebKit Commit Bot 2018-03-02 11:17:08 PST 
All reviewed patches have been landed.  Closing bug.