RESOLVED FIXED 18231
Improve support for function call nodes in SquirrelFish 
https://bugs.webkit.org/show_bug.cgi?id=18231
Summary Improve support for function call nodes in SquirrelFish
Cameron Zwarich (cpst)
Reported 2008-03-30 23:55:33 PDT
I have a patch that implements FunctionCallValueNode and corrects the handling of 'this'. I'll upload it in the next post.
Attachments
Proposed patch (8.12 KB, patch)
2008-03-31 00:02 PDT, Cameron Zwarich (cpst) 		no flags
DetailsFormatted DiffDiff
Proposed patch (now with email!) (8.11 KB, patch)
2008-03-31 00:06 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
Revised proposed patch (1.73 KB, patch)
2008-03-31 01:45 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
Proposed patch (6.78 KB, patch)
2008-04-10 20:54 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-03-31 00:02:29 PDT
Created attachment 20231 [details] Proposed patch
Cameron Zwarich (cpst)
Comment 2 2008-03-31 00:06:44 PDT
Created attachment 20232 [details] Proposed patch (now with email!) When I made a new ChangeLog after Geoff's latest patch I forgot to add my email address.
Maciej Stachowiak
Comment 3 2008-03-31 00:42:48 PDT
Comment on attachment 20232 [details] Proposed patch (now with email!) r=me
Cameron Zwarich (cpst)
Comment 4 2008-03-31 01:36:18 PDT
After r31455, I hit a SquirrelSpider regression of about 3%. I'll try to work it out.
Cameron Zwarich (cpst)
Comment 5 2008-03-31 01:45:41 PDT
Created attachment 20234 [details] Revised proposed patch Here is a fairly trivial patch containing only the support for FunctionCallValueNode. This doesn't regress SunSpider.
Maciej Stachowiak
Comment 6 2008-03-31 01:46:16 PDT
Comment on attachment 20234 [details] Revised proposed patch r=me
Julien Chaffraix
Comment 7 2008-03-31 15:18:14 PDT
Committed in revision 31456.
Cameron Zwarich (cpst)
Comment 8 2008-03-31 15:44:28 PDT
This isn't actually fixed, because I had to remove part of the patch due to a performance regression. It is required functionality, so hopefully I can find a way to avoid the performance problems by permuting the code a bit to make GCC happy.
Cameron Zwarich (cpst)
Comment 9 2008-04-10 20:54:14 PDT
Created attachment 20469 [details] Proposed patch I figured I would revisit this, and it turned out to be a SunSpider progression. What a strange world we live in.
Maciej Stachowiak
Comment 10 2008-04-10 20:57:47 PDT
Comment on attachment 20469 [details] Proposed patch r=me
Oliver Hunt
Comment 11 2008-04-11 03:26:34 PDT
Committed r31810
Note You need to log in before you can comment on or make changes to this bug.