Bug 182306 - [RenderTreeBuilder] Move RenderRubyRun::rubyBaseSafe to RenderTreeBuilder::Ruby
Summary: [RenderTreeBuilder] Move RenderRubyRun::rubyBaseSafe to RenderTreeBuilder::Ruby
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-30 13:42 PST by zalan
Modified: 2018-02-01 13:48 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.05 KB, patch)
2018-01-30 13:48 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.67 KB, patch)
2018-02-01 13:13 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-30 13:42:06 PST 
only RenderTreeBuilder::Ruby calls it.
Comment 1 Radar WebKit Bug Importer 2018-01-30 13:44:02 PST 
<rdar://problem/37041440>
Comment 2 zalan 2018-01-30 13:48:54 PST 
Created attachment 332698 [details]
Patch
Comment 3 WebKit Commit Bot 2018-01-30 14:41:01 PST 
Comment on attachment 332698 [details]
Patch

Clearing flags on attachment: 332698

Committed r227856: <https://trac.webkit.org/changeset/227856>
Comment 4 WebKit Commit Bot 2018-01-30 14:41:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2018-02-01 09:18:24 PST 
Comment on attachment 332698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332698&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:359
> +RenderRubyBase* RenderTreeBuilder::Ruby::rubyBaseSafe(RenderRubyRun& rubyRun)

Since the whole point is that this never returns null, I would change the return value to be a reference instead of a pointer.
Comment 6 zalan 2018-02-01 10:31:32 PST 
(In reply to Darin Adler from comment #5)
> Comment on attachment 332698 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332698&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:359
> > +RenderRubyBase* RenderTreeBuilder::Ruby::rubyBaseSafe(RenderRubyRun& rubyRun)
> 
> Since the whole point is that this never returns null, I would change the
> return value to be a reference instead of a pointer.
Good point! I'll do that.
Comment 7 zalan 2018-02-01 13:13:03 PST 
Reopening to attach new patch.
Comment 8 zalan 2018-02-01 13:13:04 PST 
Created attachment 332903 [details]
Patch
Comment 9 WebKit Commit Bot 2018-02-01 13:48:40 PST 
Comment on attachment 332903 [details]
Patch

Clearing flags on attachment: 332903

Committed r227980: <https://trac.webkit.org/changeset/227980>
Comment 10 WebKit Commit Bot 2018-02-01 13:48:42 PST 
All reviewed patches have been landed.  Closing bug.