Bug 182304 - WKWebView layout is sometimes wrong after rotation on iPhone X
Summary: WKWebView layout is sometimes wrong after rotation on iPhone X
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-30 13:25 PST by Tim Horton
Modified: 2018-01-30 19:03 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.52 KB, patch)
2018-01-30 13:25 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (4.47 KB, patch)
2018-01-30 15:12 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (4.93 KB, patch)
2018-01-30 15:43 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-01-30 13:25:26 PST
WKWebView layout is sometimes wrong after rotation on iPhone X
Comment 1 Tim Horton 2018-01-30 13:25:43 PST
Created attachment 332692 [details]
Patch
Comment 2 Alex Christensen 2018-01-30 14:16:28 PST
Comment on attachment 332692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332692&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2472
> +    // return UIEdgeInsetsAdd([_scrollView _contentScrollInset], self.safeAreaInsets, [_scrollView _edgesApplyingSafeAreaInsetsToContentInset]);

Did you mean to leave this commented out?
Comment 3 Tim Horton 2018-01-30 14:39:23 PST
Heh, no, this was from futzing with testing. I’ll fix it, thanks!
Comment 4 Tim Horton 2018-01-30 15:12:18 PST
Created attachment 332713 [details]
Patch
Comment 5 Tim Horton 2018-01-30 15:12:40 PST
rdar://problem/34158671
Comment 6 Tim Horton 2018-01-30 15:43:02 PST
Created attachment 332715 [details]
Patch
Comment 7 WebKit Commit Bot 2018-01-30 19:03:04 PST
Comment on attachment 332715 [details]
Patch

Clearing flags on attachment: 332715

Committed r227869: <https://trac.webkit.org/changeset/227869>
Comment 8 WebKit Commit Bot 2018-01-30 19:03:05 PST
All reviewed patches have been landed.  Closing bug.