NEW 182300
Click event node approximation does not correctly handle click targets in subframes 
https://bugs.webkit.org/show_bug.cgi?id=182300
Summary Click event node approximation does not correctly handle click targets in sub...
Andy Estes
Reported 2018-01-30 11:23:35 PST
Created attachment 332674 [details] test case See the attached test case. In Frame::nodeRespondingToClickEvents(), we sample points in a 30px radius around the touch location to find a clickable element to receive synthetic mouse events. We try to find the clickable element that has the largest intersection with the 30x30 sample rectangle. We do this by taking each node's absoluteBoundingBoxRect(), intersecting that with the the sample rectangle, and using the node with the largest intersection. However, absoluteBoundingBoxRect() returns frame-relative coordinates, so if a candidate node is in a different frame than the sample rectangle, comparing their bounding boxes is bogus. The result of this tends to be that subframes containing clickable elements are penalized in nodeRespondingToClickEvents() and you are more likely to click a same-frame element even if its intersection is smaller than the subframe element.
Attachments
test case (1.53 KB, text/html)
2018-01-30 11:23 PST, Andy Estes 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-01-30 11:30:11 PST
(In reply to Andy Estes from comment #0) > we sample points in a 30px radius 15px radius, that is (making a 30px x 30px rectangle).
Note You need to log in before you can comment on or make changes to this bug.