Bug 182299 - CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Document::updateStyleIfNeeded
Summary: CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Document::updat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-30 11:12 PST by Dean Jackson
Modified: 2018-01-30 11:46 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.29 KB, patch)
2018-01-30 11:15 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-01-30 11:12:18 PST 
CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Document::updateStyleIfNeeded
Comment 1 Dean Jackson 2018-01-30 11:12:50 PST 
<rdar://problem/36853088>
Comment 2 Dean Jackson 2018-01-30 11:15:27 PST 
Created attachment 332670 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-01-30 11:19:59 PST 
Comment on attachment 332670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332670&action=review

> Source/WebCore/svg/graphics/SVGImage.h:63
> +    void enqueueStartAnimation();

This isn't really an enqueue (there is no queue); I'd call it scheduleStartAnimation()

> LayoutTests/svg/animated-svgImage-scroll.html:37
> +        expander.style.height = "1px";
> +        if (window.testRunner) {
> +            setTimeout(function () {
> +                testRunner.notifyDone();
> +            }, 50);
> +        }
> +    }, 20);

These timeouts could probably be both 0, no?
Comment 4 Dean Jackson 2018-01-30 11:46:57 PST 
Committed r227841: <https://trac.webkit.org/changeset/227841>