WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182291
StyleBench: Generate more mutation steps
https://bugs.webkit.org/show_bug.cgi?id=182291
Summary
StyleBench: Generate more mutation steps
Antti Koivisto
Reported
2018-01-30 06:45:07 PST
The test should be doing multiple rounds of mutations in a single document to test what is supposed to test (like it did before
r227756
).
Attachments
patch
(3.79 KB, patch)
2018-01-30 06:54 PST
,
Antti Koivisto
rniwa
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2018-01-30 06:54:13 PST
Created
attachment 332652
[details]
patch
Ryosuke Niwa
Comment 2
2018-01-30 13:55:38 PST
Comment on
attachment 332652
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=332652&action=review
> PerformanceTests/StyleBench/resources/tests.js:5 > + steps.push(new BenchmarkTestStep(`Adding classes, step ${i}`, (bench, contentWindow, contentDocument) => {
Instead of explicitly saying step, why not just `Adding classes - ${i}`. Ditto for the rest.
Antti Koivisto
Comment 3
2018-01-30 14:08:53 PST
https://trac.webkit.org/r227850
Radar WebKit Bug Importer
Comment 4
2018-01-30 14:10:24 PST
<
rdar://problem/37042601
>
Ryosuke Niwa
Comment 5
2018-01-30 16:32:10 PST
https://trac.webkit.org/changeset/227863
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug