Bug 182291 - StyleBench: Generate more mutation steps
Summary: StyleBench: Generate more mutation steps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-30 06:45 PST by Antti Koivisto
Modified: 2018-01-30 16:32 PST (History)
5 users (show)

See Also:


Attachments
patch (3.79 KB, patch)
2018-01-30 06:54 PST, Antti Koivisto
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-01-30 06:45:07 PST
The test should be doing multiple rounds of mutations in a single document to test what is supposed to test (like it did before r227756).
Comment 1 Antti Koivisto 2018-01-30 06:54:13 PST
Created attachment 332652 [details]
patch
Comment 2 Ryosuke Niwa 2018-01-30 13:55:38 PST
Comment on attachment 332652 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332652&action=review

> PerformanceTests/StyleBench/resources/tests.js:5
> +        steps.push(new BenchmarkTestStep(`Adding classes, step ${i}`, (bench, contentWindow, contentDocument) => {

Instead of explicitly saying step, why not just `Adding classes - ${i}`.
Ditto for the rest.
Comment 3 Antti Koivisto 2018-01-30 14:08:53 PST
https://trac.webkit.org/r227850
Comment 4 Radar WebKit Bug Importer 2018-01-30 14:10:24 PST
<rdar://problem/37042601>
Comment 5 Ryosuke Niwa 2018-01-30 16:32:10 PST
https://trac.webkit.org/changeset/227863