Bug 182284 - [WebVR][GTK][WPE] Exclude OpenVR from tarballs
Summary: [WebVR][GTK][WPE] Exclude OpenVR from tarballs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 177298
  Show dependency treegraph
 
Reported: 2018-01-30 02:07 PST by Sergio Villar Senin
Modified: 2018-01-30 08:19 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.28 KB, patch)
2018-01-30 02:10 PST, Sergio Villar Senin
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2018-01-30 02:07:58 PST
[WebVR][GTK][WPE] Exclude OpenVR from tarballs
Comment 1 Sergio Villar Senin 2018-01-30 02:10:30 PST
Created attachment 332640 [details]
Patch
Comment 2 Michael Catanzaro 2018-01-30 05:59:04 PST
Comment on attachment 332640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332640&action=review

Thanks

> Source/cmake/OptionsWPE.cmake:51
> +WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})

This is right. I would just move it higher up in the file, above if (CMAKE_SYSTEM_NAME MATCHES "Linux"), and add a comment to parallel the other sections:

# Private options specific to the WPE port.

It won't be long before there are more such options.
Comment 3 Sergio Villar Senin 2018-01-30 08:18:33 PST
Committed r227788: <https://trac.webkit.org/changeset/227788>
Comment 4 Radar WebKit Bug Importer 2018-01-30 08:19:16 PST
<rdar://problem/37029301>