Bug 182283 - [JHBuild] Add gstreamer-vaapi in moduleset
Summary: [JHBuild] Add gstreamer-vaapi in moduleset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-30 01:01 PST by Philippe Normand
Modified: 2018-01-31 08:14 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2018-01-30 01:21 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (11.49 MB, application/zip)
2018-01-30 03:11 PST, EWS Watchlist
no flags Details
Patch (4.55 KB, patch)
2018-01-30 08:04 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2018-01-30 09:13 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2018-01-30 09:53 PST, Philippe Normand
clopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-01-30 01:01:44 PST
.
Comment 1 Philippe Normand 2018-01-30 01:21:10 PST
Created attachment 332636 [details]
Patch
Comment 2 EWS Watchlist 2018-01-30 03:11:12 PST
Comment on attachment 332636 [details]
Patch

Attachment 332636 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6259247

New failing tests:
http/tests/preload/onerror_event.html
Comment 3 EWS Watchlist 2018-01-30 03:11:23 PST
Created attachment 332644 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Philippe Normand 2018-01-30 08:04:08 PST
Created attachment 332654 [details]
Patch
Comment 5 Carlos Alberto Lopez Perez 2018-01-30 08:55:13 PST
Comment on attachment 332654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332654&action=review

> Tools/Scripts/webkitpy/port/gtk.py:120
> +        # Make sure va-api support gets disabled because it's incompatible with Mesa's softGL driver.
> +        environment['LIBVA_DRIVERS_PATH'] = "/tmp"

Likely a minor issue, but I'm a bit uncomfortable with this.
This means each time I run layout tests, something will try to load some library from /tmp that won't exist, ins't it?
But it also means that (theoretically) its possible for an attacker to put in /tmp some crafted library and trick me into executing it.
Instead of /tmp can you look for another directory that is not world-writable? Perhaps another way of disabling this is setting "LIBVA_DRIVER_NAME=null"
Comment 6 Philippe Normand 2018-01-30 09:13:54 PST
Created attachment 332659 [details]
Patch
Comment 7 Carlos Alberto Lopez Perez 2018-01-30 09:41:06 PST
Comment on attachment 332659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332659&action=review

> Tools/Scripts/webkitpy/port/gtk.py:120
>      def setup_environ_for_server(self, server_name=None):
>          environment = super(GtkPort, self).setup_environ_for_server(server_name)
> +        # Make sure va-api support gets disabled because it's incompatible with Mesa's softGL driver.
> +        environment['LIBVA_DRIVER_NAME'] = "null"

I think this is the wrong place to set this environment variable.
Because we should only do that when the driver is either xvfb or weston (which are the ones using mesa software render). 
The right place would be this one: https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/gtk.py?rev=227427#L132
Comment 8 Philippe Normand 2018-01-30 09:53:20 PST
Created attachment 332663 [details]
Patch
Comment 9 Carlos Alberto Lopez Perez 2018-01-30 09:59:19 PST
Comment on attachment 332663 [details]
Patch

Interesting mix of spaces we had there. Thanks!
Comment 10 Carlos Garcia Campos 2018-01-30 23:49:31 PST
Why are we adding this to the jhbuild if it's going to be disabled when running tests?
Comment 11 Philippe Normand 2018-01-31 01:21:25 PST
(In reply to Carlos Garcia Campos from comment #10)
> Why are we adding this to the jhbuild if it's going to be disabled when
> running tests?

for MiniBrowser testing, mostly.
Comment 12 Philippe Normand 2018-01-31 08:12:17 PST
Committed r227901: <https://trac.webkit.org/changeset/227901>
Comment 13 Radar WebKit Bug Importer 2018-01-31 08:14:02 PST
<rdar://problem/37070671>