Bug 182259 - Clean up API after bugs 178240 and 176474
Summary: Clean up API after bugs 178240 and 176474
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-29 12:58 PST by Alex Christensen
Modified: 2018-01-29 17:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.15 KB, patch)
2018-01-29 13:02 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2018-01-29 15:02 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.51 KB, patch)
2018-01-29 15:33 PST, Alex Christensen 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-01-29 12:58:11 PST 
Clean up API after bugs 178240 and 176474
Comment 1 Alex Christensen 2018-01-29 13:02:43 PST 
Created attachment 332572 [details]
Patch
Comment 2 Sam Weinig 2018-01-29 14:58:14 PST 
Comment on attachment 332572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332572&action=review

> Source/WebKit/ChangeLog:9
> +        * UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
> +        * UIProcess/API/Cocoa/WKWebViewPrivate.h:

Please add information about why these changes are being made.
Comment 3 Alex Christensen 2018-01-29 15:02:42 PST 
Created attachment 332585 [details]
Patch
Comment 4 Alex Christensen 2018-01-29 15:33:06 PST 
Created attachment 332589 [details]
Patch
Comment 5 mitz 2018-01-29 15:51:42 PST 
Comment on attachment 332589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332589&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:588
> +    EXPECT_EQ(static_cast<NSUInteger>([[change objectForKey:NSKeyValueChangeNewKey] integerValue]), _WKRectEdgeLeft | _WKRectEdgeRight);

Why not just do unsignedIntegerValue?
Comment 6 Alex Christensen 2018-01-29 17:27:31 PST 
trac.webkit.org/r227765
Comment 7 Radar WebKit Bug Importer 2018-01-29 17:30:49 PST 
<rdar://problem/37009361>