Bug 182258 - StyleBench: Remove : from a test name
Summary: StyleBench: Remove : from a test name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-29 12:55 PST by Antti Koivisto
Modified: 2018-01-29 18:06 PST (History)
6 users (show)

See Also:


Attachments
patch (1.21 KB, patch)
2018-01-29 12:56 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-01-29 12:55:14 PST
It breaks reporting
Comment 1 Antti Koivisto 2018-01-29 12:56:56 PST
Created attachment 332571 [details]
patch
Comment 2 Ryosuke Niwa 2018-01-29 13:19:13 PST
Comment on attachment 332571 [details]
patch

Actually, let's hold off on landing this until I can verify that the math I'm doing in run-perf-tests is right.
Comment 3 Ryosuke Niwa 2018-01-29 17:39:37 PST
Comment on attachment 332571 [details]
patch

Okay. I've temporarily skipped StyleBench explicitly in https://trac.webkit.org/r227767 since we need to fix webkit.org/b/182088 as well before the test could run.
Comment 4 Ryosuke Niwa 2018-01-29 17:39:54 PST
But we need this patch to make run-benchmark work with StyleBench so landing this now.
Comment 5 WebKit Commit Bot 2018-01-29 18:04:14 PST
Comment on attachment 332571 [details]
patch

Clearing flags on attachment: 332571

Committed r227769: <https://trac.webkit.org/changeset/227769>
Comment 6 WebKit Commit Bot 2018-01-29 18:04:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-29 18:06:28 PST
<rdar://problem/37010610>