WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182258
StyleBench: Remove : from a test name
https://bugs.webkit.org/show_bug.cgi?id=182258
Summary
StyleBench: Remove : from a test name
Antti Koivisto
Reported
2018-01-29 12:55:14 PST
It breaks reporting
Attachments
patch
(1.21 KB, patch)
2018-01-29 12:56 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2018-01-29 12:56:56 PST
Created
attachment 332571
[details]
patch
Ryosuke Niwa
Comment 2
2018-01-29 13:19:13 PST
Comment on
attachment 332571
[details]
patch Actually, let's hold off on landing this until I can verify that the math I'm doing in run-perf-tests is right.
Ryosuke Niwa
Comment 3
2018-01-29 17:39:37 PST
Comment on
attachment 332571
[details]
patch Okay. I've temporarily skipped StyleBench explicitly in
https://trac.webkit.org/r227767
since we need to fix
webkit.org/b/182088
as well before the test could run.
Ryosuke Niwa
Comment 4
2018-01-29 17:39:54 PST
But we need this patch to make run-benchmark work with StyleBench so landing this now.
WebKit Commit Bot
Comment 5
2018-01-29 18:04:14 PST
Comment on
attachment 332571
[details]
patch Clearing flags on attachment: 332571 Committed
r227769
: <
https://trac.webkit.org/changeset/227769
>
WebKit Commit Bot
Comment 6
2018-01-29 18:04:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-01-29 18:06:28 PST
<
rdar://problem/37010610
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug