Bug 182242 - WebDriver: properly recover w3c tests after a webdriver server crash
Summary: WebDriver: properly recover w3c tests after a webdriver server crash
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-01-29 08:28 PST by Carlos Garcia Campos
Modified: 2018-01-29 08:47 PST (History)
5 users (show)

See Also:

Patch (7.00 KB, patch)
2018-01-29 08:34 PST, Carlos Garcia Campos
clopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-01-29 08:28:15 PST
When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by relaunching the server after every test failure, because other failures even when not crashing the server might leve it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
Comment 1 Carlos Garcia Campos 2018-01-29 08:34:13 PST
Created attachment 332544 [details]
Comment 2 EWS Watchlist 2018-01-29 08:35:31 PST
Attachment 332544 [details] did not pass style-queue:

ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:149:  [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:150:  [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:151:  [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:152:  [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'server_config' member  [pylint/E1101] [5]
Total errors found: 4 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2018-01-29 08:46:03 PST
Committed r227732: <https://trac.webkit.org/changeset/227732>
Comment 4 Radar WebKit Bug Importer 2018-01-29 08:47:20 PST