Bug 182231 - Add the support for running Speedometer 2.0 to run-benchmark
Summary: Add the support for running Speedometer 2.0 to run-benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-28 23:37 PST by Ryosuke Niwa
Modified: 2018-01-29 10:18 PST (History)
7 users (show)

See Also:


Attachments
Adds the support (32.11 KB, patch)
2018-01-29 00:01 PST, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-01-28 23:37:53 PST
Make it possible to run Speedometer 2.0 using run-benchmark.
Comment 1 Radar WebKit Bug Importer 2018-01-28 23:38:28 PST
<rdar://problem/36976267>
Comment 2 Ryosuke Niwa 2018-01-29 00:01:45 PST
Created attachment 332514 [details]
Adds the support
Comment 3 Antti Koivisto 2018-01-29 07:53:19 PST
Comment on attachment 332514 [details]
Adds the support

View in context: https://bugs.webkit.org/attachment.cgi?id=332514&action=review

> Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan:5
> +    "svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@﷒0﷓",
> +    "webserver_benchmark_patch": "data/patches/webserver/Speedometer2.patch",

Does this cover StyleBench too?
Comment 4 Ryosuke Niwa 2018-01-29 10:10:15 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 332514 [details]
> Adds the support
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332514&action=review
> 
> > Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan:5
> > +    "svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@﷒0﷓",
> > +    "webserver_benchmark_patch": "data/patches/webserver/Speedometer2.patch",
> 
> Does this cover StyleBench too?

No, we have to add a new plan file.
Comment 5 Ryosuke Niwa 2018-01-29 10:18:39 PST
Committed r227739: <https://trac.webkit.org/changeset/227739>