Bug 182229 - Make it possible for apps that use both WK1 and WK2 to use MessagePorts
Summary: Make it possible for apps that use both WK1 and WK2 to use MessagePorts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-28 21:58 PST by Brady Eidson
Modified: 2018-01-29 11:55 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.47 KB, patch)
2018-01-28 22:10 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (14.48 KB, patch)
2018-01-28 23:12 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
API crash log (66.54 KB, text/plain)
2018-01-29 11:55 PST, Matt Lewis 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-01-28 21:58:15 PST 
Make it possible for apps that use both WK1 and WK2 to use MessagePorts

The UIProcess-side of WK2 MessagePorts does not actually need to set the shared singleton provider as long as WebCore is updated to rely on it.
Comment 1 Brady Eidson 2018-01-28 21:58:33 PST 
rdar://problem/36739730
Comment 2 Brady Eidson 2018-01-28 22:10:34 PST 
Created attachment 332509 [details]
Patch
Comment 3 EWS Watchlist 2018-01-28 22:13:31 PST 
Attachment 332509 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/messageports/MessagePortChannelRegistry.h:38:  The parameter name "provider" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2018-01-28 23:12:47 PST 
Created attachment 332511 [details]
Patch
Comment 5 WebKit Commit Bot 2018-01-29 09:45:22 PST 
Comment on attachment 332511 [details]
Patch

Clearing flags on attachment: 332511

Committed r227737: <https://trac.webkit.org/changeset/227737>
Comment 6 WebKit Commit Bot 2018-01-29 09:45:23 PST 
All reviewed patches have been landed.  Closing bug.