RESOLVED FIXED 182229
Make it possible for apps that use both WK1 and WK2 to use MessagePorts 
https://bugs.webkit.org/show_bug.cgi?id=182229
Summary Make it possible for apps that use both WK1 and WK2 to use MessagePorts
Brady Eidson
Reported 2018-01-28 21:58:15 PST
Make it possible for apps that use both WK1 and WK2 to use MessagePorts The UIProcess-side of WK2 MessagePorts does not actually need to set the shared singleton provider as long as WebCore is updated to rely on it.
Attachments
Patch (14.47 KB, patch)
2018-01-28 22:10 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (14.48 KB, patch)
2018-01-28 23:12 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
API crash log (66.54 KB, text/plain)
2018-01-29 11:55 PST, Matt Lewis 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2018-01-28 21:58:33 PST
rdar://problem/36739730
Brady Eidson
Comment 2 2018-01-28 22:10:34 PST
Created attachment 332509 [details] Patch
EWS Watchlist
Comment 3 2018-01-28 22:13:31 PST
Attachment 332509 [details] did not pass style-queue: ERROR: Source/WebCore/dom/messageports/MessagePortChannelRegistry.h:38: The parameter name "provider" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2018-01-28 23:12:47 PST
Created attachment 332511 [details] Patch
WebKit Commit Bot
Comment 5 2018-01-29 09:45:22 PST
Comment on attachment 332511 [details] Patch Clearing flags on attachment: 332511 Committed r227737: <https://trac.webkit.org/changeset/227737>
WebKit Commit Bot
Comment 6 2018-01-29 09:45:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.