WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182220
Make MarkedBlock::Footer bigger
https://bugs.webkit.org/show_bug.cgi?id=182220
Summary
Make MarkedBlock::Footer bigger
Filip Pizlo
Reported
2018-01-27 20:38:02 PST
Patch forthcoming.
Attachments
the patch
(19.33 KB, patch)
2018-01-27 20:42 PST
,
Filip Pizlo
jfbastien
: review+
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews201 for win-future
(11.51 MB, application/zip)
2018-01-27 23:20 PST
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews206 for win-future
(11.55 MB, application/zip)
2018-01-28 01:53 PST
,
EWS Watchlist
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-01-27 20:38:32 PST
<
rdar://problem/36953788
>
Filip Pizlo
Comment 2
2018-01-27 20:42:00 PST
Created
attachment 332487
[details]
the patch
EWS Watchlist
Comment 3
2018-01-27 23:20:47 PST
Comment on
attachment 332487
[details]
the patch
Attachment 332487
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/6237943
New failing tests: js/dom/array-with-double-assign.html js/dom/array-with-double-push.html
EWS Watchlist
Comment 4
2018-01-27 23:20:58 PST
Created
attachment 332489
[details]
Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
EWS Watchlist
Comment 5
2018-01-28 01:53:30 PST
Comment on
attachment 332487
[details]
the patch
Attachment 332487
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/6238666
New failing tests: js/dom/array-with-double-assign.html js/dom/array-with-double-push.html
EWS Watchlist
Comment 6
2018-01-28 01:53:41 PST
Created
attachment 332490
[details]
Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
JF Bastien
Comment 7
2018-01-28 08:56:12 PST
Comment on
attachment 332487
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=332487&action=review
r=me since this mostly moves stuff around.
> Source/JavaScriptCore/heap/MarkedBlockInlines.h:148 > MarkedBlock::Handle* fencedThis = fenceBefore.consume(this);
So these are the only things that can change, and none below need to be consumed? I'm guessing you thought about it, but worth asking anyways.
Filip Pizlo
Comment 8
2018-01-28 09:31:12 PST
(In reply to JF Bastien from
comment #7
)
> Comment on
attachment 332487
[details]
> the patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=332487&action=review
> > r=me since this mostly moves stuff around. > > > Source/JavaScriptCore/heap/MarkedBlockInlines.h:148 > > MarkedBlock::Handle* fencedThis = fenceBefore.consume(this); > > So these are the only things that can change, and none below need to be > consumed? I'm guessing you thought about it, but worth asking anyways.
It's simple, really: - We're taking a read lock on the block. - We're threading all pointers to the block through the fence. - The block lock doesn't have any state that it protects that isn't on the block/footer/handle, all of which get threaded through the fence. Therefore, we're GTG.
Filip Pizlo
Comment 9
2018-01-28 09:32:27 PST
(In reply to Build Bot from
comment #5
)
> Comment on
attachment 332487
[details]
> the patch > >
Attachment 332487
[details]
did not pass win-ews (win): > Output:
http://webkit-queues.webkit.org/results/6238666
> > New failing tests: > js/dom/array-with-double-assign.html > js/dom/array-with-double-push.html
Based on this I'll test 32-bit. If 32-bit Mac is OK then I will ignore this.
Filip Pizlo
Comment 10
2018-01-28 09:50:39 PST
(In reply to Filip Pizlo from
comment #9
)
> (In reply to Build Bot from
comment #5
) > > Comment on
attachment 332487
[details]
> > the patch > > > >
Attachment 332487
[details]
did not pass win-ews (win): > > Output:
http://webkit-queues.webkit.org/results/6238666
> > > > New failing tests: > > js/dom/array-with-double-assign.html > > js/dom/array-with-double-push.html > > Based on this I'll test 32-bit. > > If 32-bit Mac is OK then I will ignore this.
32-bit JSC tests are fine. I'll test 32-bit layout tests next.
Filip Pizlo
Comment 11
2018-01-28 10:28:45 PST
(In reply to Filip Pizlo from
comment #10
)
> (In reply to Filip Pizlo from
comment #9
) > > (In reply to Build Bot from
comment #5
) > > > Comment on
attachment 332487
[details]
> > > the patch > > > > > >
Attachment 332487
[details]
did not pass win-ews (win): > > > Output:
http://webkit-queues.webkit.org/results/6238666
> > > > > > New failing tests: > > > js/dom/array-with-double-assign.html > > > js/dom/array-with-double-push.html > > > > Based on this I'll test 32-bit. > > > > If 32-bit Mac is OK then I will ignore this. > > 32-bit JSC tests are fine. I'll test 32-bit layout tests next.
I can't build 32-bit. :-( I'll try a different computer.
Filip Pizlo
Comment 12
2018-01-28 11:07:41 PST
(In reply to Filip Pizlo from
comment #11
)
> (In reply to Filip Pizlo from
comment #10
) > > (In reply to Filip Pizlo from
comment #9
) > > > (In reply to Build Bot from
comment #5
) > > > > Comment on
attachment 332487
[details]
> > > > the patch > > > > > > > >
Attachment 332487
[details]
did not pass win-ews (win): > > > > Output:
http://webkit-queues.webkit.org/results/6238666
> > > > > > > > New failing tests: > > > > js/dom/array-with-double-assign.html > > > > js/dom/array-with-double-push.html > > > > > > Based on this I'll test 32-bit. > > > > > > If 32-bit Mac is OK then I will ignore this. > > > > 32-bit JSC tests are fine. I'll test 32-bit layout tests next. > > I can't build 32-bit. :-( I'll try a different computer.
I can't build 32-bit at all. Ima land this.
Filip Pizlo
Comment 13
2018-01-28 11:08:32 PST
Landed in
https://trac.webkit.org/changeset/227718/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug