Bug 182211 - [WebAuthN] Add a compile-time feature flag
Summary: [WebAuthN] Add a compile-time feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2018-01-26 22:31 PST by Jiewen Tan
Modified: 2018-01-29 17:21 PST (History)
5 users (show)

See Also:

Attachments
Patch (79.74 KB, patch)
2018-01-26 22:44 PST, Jiewen Tan 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (79.85 KB, patch)
2018-01-29 14:34 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-01-26 22:31:14 PST 
Add a feature flag for WebAuthN.
Comment 1 Radar WebKit Bug Importer 2018-01-26 22:31:42 PST 
<rdar://problem/36936365>
Comment 2 Jiewen Tan 2018-01-26 22:44:38 PST 
Created attachment 332460 [details]
Patch
Comment 3 Brent Fulgham 2018-01-28 16:49:10 PST 
Comment on attachment 332460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332460&action=review

Please revise the title to reflect that you are adding a COMPILE TIME feature flag, since we already had a runtime flag for enabling/disabling this experimental feature.

> Source/JavaScriptCore/ChangeLog:3
> +        [WebAuthN] Add a feature flag

Add a compile-time feature flag

> Source/WebCore/ChangeLog:9
> +        Add a feature flag for WebAuthN as most of the functionalities are platform

"Add a compile-time feature flag"

"most of the functionality is platform dependent"
Comment 4 Jiewen Tan 2018-01-29 14:29:48 PST 
Comment on attachment 332460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332460&action=review

Thanks Brent for r+ the patch.

>> Source/JavaScriptCore/ChangeLog:3
>> +        [WebAuthN] Add a feature flag
> 
> Add a compile-time feature flag

Fixed.

>> Source/WebCore/ChangeLog:9
>> +        Add a feature flag for WebAuthN as most of the functionalities are platform
> 
> "Add a compile-time feature flag"
> 
> "most of the functionality is platform dependent"

Fixed.
Comment 5 Jiewen Tan 2018-01-29 14:34:32 PST 
Created attachment 332582 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-01-29 17:20:24 PST 
Comment on attachment 332582 [details]
Patch for landing

Clearing flags on attachment: 332582

Committed r227764: <https://trac.webkit.org/changeset/227764>