Bug 182199 - Resource Load Statistics: Introduce debug mode as experimental feature
Summary: Resource Load Statistics: Introduce debug mode as experimental feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-26 17:14 PST by John Wilander
Modified: 2018-01-29 16:26 PST (History)
7 users (show)

See Also:

Attachments
Patch (17.60 KB, patch)
2018-01-26 17:24 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (17.62 KB, patch)
2018-01-29 10:33 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (17.64 KB, patch)
2018-01-29 12:18 PST, John Wilander 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-01-26 17:14:44 PST 
We want a debug mode for developers where ITP has significantly shorter timeouts, outputs console info on internal state, etc. We should start by introducing it as an experimental feature with some simple settings changes.
Comment 1 Radar WebKit Bug Importer 2018-01-26 17:15:10 PST 
<rdar://problem/36930364>
Comment 2 John Wilander 2018-01-26 17:24:26 PST 
Created attachment 332437 [details]
Patch
Comment 3 John Wilander 2018-01-29 10:33:51 PST 
Created attachment 332554 [details]
Patch
Comment 4 John Wilander 2018-01-29 12:18:48 PST 
Created attachment 332566 [details]
Patch
Comment 5 Alex Christensen 2018-01-29 13:49:22 PST 
Comment on attachment 332566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332566&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1196
>  \ No newline at end of file

I hope it wouldn't hurt to add a newline at the end of this file.
Comment 6 John Wilander 2018-01-29 13:54:27 PST 
Comment on attachment 332566 [details]
Patch

Thanks, Alex! Lack of a newline seems to mess up revision tracking both in Xcode and on Bugzilla, as can be seen in the formatted diff.
Comment 7 John Wilander 2018-01-29 13:56:07 PST 
I think what happens is that by adding a newline to the previous entry in order to add your new one, you touch the last line of the previous entry and thus "revise" it.

But I see what you're saying. Let's hope a newline is fine.
Comment 8 WebKit Commit Bot 2018-01-29 14:17:28 PST 
Comment on attachment 332566 [details]
Patch

Rejecting attachment 332566 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 332566, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 227753 = c7d8175b884322f3dc6e97dd377b80344b80a3e5
r227754 = 19b1b43411899ad87c792acf81d60c4f9058a581
r227755 = 2d0589b491cc81522516c9eb3901667ac9a870c4
r227756 = 5cadb9d3c3216a3aa56f01b489c4dabbb3ca71de
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/6252911
Comment 9 John Wilander 2018-01-29 16:09:20 PST 
Comment on attachment 332566 [details]
Patch

Trying the commit queue again.
Comment 10 John Wilander 2018-01-29 16:10:06 PST 
Comment on attachment 332566 [details]
Patch

Nah.
Comment 11 John Wilander 2018-01-29 16:26:00 PST 
Committed r227762: <https://trac.webkit.org/changeset/227762>